DevTools: Promisify Profiler and HeapProfiler domains

third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1017 matching lines @@
    */
   isInstantProfile() {
     return true;
   }
 
   /**
    * @override
    * @return {boolean}
    */
   buttonClicked() {
-    this._takeHeapSnapshot(function() {});
+    this._takeHeapSnapshot();
     Host.userMetrics.actionTaken(Host.UserMetrics.Action.ProfilesHeapProfileTaken);
     return false;
   }
 
   get treeItemTitle() {
     return Common.UIString('HEAP SNAPSHOTS');
   }
 
   get description() {
     return Common.UIString(
         'Heap snapshot profiles show memory distribution among your page\'s JavaScript objects and related DOM nodes.');
   }
 
   /**
    * @override
    * @param {string} title
    * @return {!Profiler.ProfileHeader}
    */
   createProfileLoadedFromFile(title) {
     return new Profiler.HeapProfileHeader(null, this, title);
   }
 
-  _takeHeapSnapshot(callback) {
+  async _takeHeapSnapshot() {
     if (this.profileBeingRecorded())
       return;
     var heapProfilerModel = UI.context.flavor(SDK.HeapProfilerModel);
     if (!heapProfilerModel)
       return;
 
     var profile = new Profiler.HeapProfileHeader(heapProfilerModel, this);
     this.setProfileBeingRecorded(profile);
     this.addProfile(profile);
     profile.updateStatus(Common.UIString('Snapshotting\u2026'));
 
-    heapProfilerModel.takeHeapSnapshot(true).then(success => {
-      var profile = this.profileBeingRecorded();
-      profile.title = Common.UIString('Snapshot %d', profile.uid);
-      profile._finishLoad();
-      this.setProfileBeingRecorded(null);
-      this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, profile);
-      callback();
-    });
+    await heapProfilerModel.takeHeapSnapshot(true);
+    // ------------ ASYNC ------------
+    profile = this.profileBeingRecorded();
+    profile.title = Common.UIString('Snapshot %d', profile.uid);
+    profile._finishLoad();
+    this.setProfileBeingRecorded(null);
+    this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, profile);
   }
 
   /**
    * @param {!Common.Event} event
    */
   _addHeapSnapshotChunk(event) {
     if (!this.profileBeingRecorded())
       return;
     var chunk = /** @type {string} */ (event.data);
     this.profileBeingRecorded().transferChunk(chunk);
@@ skipping 148 matching lines @@
     this.setProfileBeingRecorded(new Profiler.HeapProfileHeader(heapProfilerModel, this, undefined));
     this._profileSamples = new Profiler.TrackingHeapSnapshotProfileType.Samples();
     this.profileBeingRecorded()._profileSamples = this._profileSamples;
     this._recording = true;
     this.addProfile(/** @type {!Profiler.ProfileHeader} */ (this.profileBeingRecorded()));
     this.profileBeingRecorded().updateStatus(Common.UIString('Recording\u2026'));
     this.dispatchEventToListeners(Profiler.TrackingHeapSnapshotProfileType.TrackingStarted);
     return heapProfilerModel;
   }
 
-  _stopRecordingProfile() {
+  async _stopRecordingProfile() {
     this.profileBeingRecorded().updateStatus(Common.UIString('Snapshotting\u2026'));
-    /**
-     * @param {boolean} success
-     * @this {Profiler.HeapSnapshotProfileType}
-     */
-    function didTakeHeapSnapshot(success) {
-      var profile = this.profileBeingRecorded();
-      if (!profile)
-        return;
-      profile._finishLoad();
-      this._profileSamples = null;
-      this.setProfileBeingRecorded(null);
-      this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, profile);
-    }
-
-    this.profileBeingRecorded()._heapProfilerModel.stopTrackingHeapObjects(true).then(didTakeHeapSnapshot.bind(this));
+    var stopPromise = this.profileBeingRecorded()._heapProfilerModel.stopTrackingHeapObjects(true);
     this._recording = false;
     this.dispatchEventToListeners(Profiler.TrackingHeapSnapshotProfileType.TrackingStopped);
+    await stopPromise;
+    // ------------ ASYNC ------------
+    var profile = this.profileBeingRecorded();
+    if (!profile)
+      return;
+    profile._finishLoad();
+    this._profileSamples = null;
+    this.setProfileBeingRecorded(null);
+    this.dispatchEventToListeners(Profiler.ProfileType.Events.ProfileComplete, profile);
   }
 
   _toggleRecording() {
     if (this._recording)
       this._stopRecordingProfile();
     else
       this._startRecordingProfile();
     return this._recording;
   }
 
@@ skipping 850 matching lines @@
       name.textContent = UI.beautifyFunctionName(frame.functionName);
       if (frame.scriptId) {
         var urlElement = this._linkifier.linkifyScriptLocation(
             this._heapProfilerModel ? this._heapProfilerModel.target() : null, String(frame.scriptId), frame.scriptName,
             frame.line - 1, frame.column - 1);
         frameDiv.appendChild(urlElement);
       }
     }
   }
 };