DevTools: Promisify Profiler and HeapProfiler domains

third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js

 /**
  * @unrestricted
  */
 SDK.HeapProfilerModel = class extends SDK.SDKModel {
   /**
    * @param {!SDK.Target} target
    */
   constructor(target) {
     super(target);
     target.registerHeapProfilerDispatcher(new SDK.HeapProfilerDispatcher(this));
@@ skipping 23 matching lines @@
     this._enabled = true;
     this._heapProfilerAgent.enable();
   }
 
   startSampling() {
     var defaultSamplingIntervalInBytes = 16384;
     this._heapProfilerAgent.startSampling(defaultSamplingIntervalInBytes);
   }
 
   /**
-   * @return {!Promise.<?Protocol.HeapProfiler.SamplingHeapProfile>}
+   * @return {!Promise<?Protocol.HeapProfiler.SamplingHeapProfile>}
    */
   stopSampling() {
     this._isRecording = false;
-    return this._heapProfilerAgent.stopSampling((error, profile) => error ? null : profile);
+    return this._heapProfilerAgent.stopSampling();
   }
 
   /**
    * @return {!Promise}
    */
   collectGarbage() {
     return this._heapProfilerAgent.collectGarbage();
   }
 
   /**
    * @param {string} objectId
    * @return {!Promise<?string>}
    */
   snapshotObjectIdForObjectId(objectId) {
-    return this._heapProfilerAgent.getHeapObjectId(objectId, (error, result) => error ? null : result);
+    return this._heapProfilerAgent.getHeapObjectId(objectId);
   }
 
   /**
    * @param {string} snapshotObjectId
    * @param {string} objectGroupName
    * @return {!Promise<?SDK.RemoteObject>}
    */
   objectForSnapshotObjectId(snapshotObjectId, objectGroupName) {
-    return this._heapProfilerAgent.getObjectByHeapObjectId(snapshotObjectId, objectGroupName, (error, result) => {
-      if (error || !result.type)
-        return null;
-      return this._runtimeModel.createRemoteObject(result);
-    });
+    return this._heapProfilerAgent.getObjectByHeapObjectId(snapshotObjectId, objectGroupName)
+        .then(result => result && result.type ? this._runtimeModel.createRemoteObject(result) : null);
   }
 
   /**
    * @param {string} snapshotObjectId
    * @return {!Promise}
    */
   addInspectedHeapObject(snapshotObjectId) {
     return this._heapProfilerAgent.addInspectedHeapObject(snapshotObjectId);
   }
 
   /**
    * @param {boolean} reportProgress
    * @return {!Promise<boolean>}
    */
   takeHeapSnapshot(reportProgress) {
-    return this._heapProfilerAgent.takeHeapSnapshot(reportProgress, error => !error);
+    return this._heapProfilerAgent.invoke_takeHeapSnapshot({reportProgress: reportProgress})

[dgozman, 2017/05/02 20:03:41]

Can we do something here? Do you have an idea how many methods need this
boolean? Maybe even these ones don't?

[alph, 2017/05/02 22:48:06]

Done.

+        .then(response => !response[Protocol.Error]);
   }
 
   /**
    * @param {boolean} recordAllocationStacks
    * @return {!Promise}
    */
   startTrackingHeapObjects(recordAllocationStacks) {
     return this._heapProfilerAgent.startTrackingHeapObjects(recordAllocationStacks);
   }
 
   /**
    * @param {boolean} reportProgress
    * @return {!Promise<boolean>}
    */
   stopTrackingHeapObjects(reportProgress) {
-    return this._heapProfilerAgent.stopTrackingHeapObjects(reportProgress, error => !error);
+    return this._heapProfilerAgent.invoke_stopTrackingHeapObjects({reportProgress: reportProgress})
+        .then(response => !response[Protocol.Error]);
   }
 
   /**
-   * @param {!Array.<number>} samples
+   * @param {!Array<number>} samples
    */
   heapStatsUpdate(samples) {
     this.dispatchEventToListeners(SDK.HeapProfilerModel.Events.HeapStatsUpdate, samples);
   }
 
   /**
    * @param {number} lastSeenObjectId
    * @param {number} timestamp
    */
   lastSeenObjectId(lastSeenObjectId, timestamp) {
@@ skipping 78 matching lines @@
     this._heapProfilerModel.reportHeapSnapshotProgress(done, total, finished);
   }
 
   /**
    * @override
    */
   resetProfiles() {
     this._heapProfilerModel.resetProfiles();
   }
 };