Chromium Code Reviews Chromium Code Reviews
Issue 2850253002:
Change chrome://net-export/ UI flow. (Closed)
| Index: components/net_log/resources/net_export.html |
| diff --git a/components/net_log/resources/net_export.html b/components/net_log/resources/net_export.html |
| index 48d137250700390ee78859859eb47eb4597d81f9..233d19245201abc6f9249ea89b0736dff5345863 100644 |
| --- a/components/net_log/resources/net_export.html |
| +++ b/components/net_log/resources/net_export.html |
| @@ -19,87 +19,126 @@ |
| <title>Network Log Export</title> |
| </head> |
| <body> |
| - <h2>Network Log Export</h2> |
| - <div id="net-export-main"> |
| - <div> |
| - <button id="export-view-start-data" disabled> |
| - <span class="export-view-logging-enabled">Start Logging to Disk</span> |
| - <span class="export-view-logging-disabled">Logging to Disk...</span> |
| - <if expr="is_ios or is_android"> |
| - <div class="warning" id="export-view-mobile-deletes-log-text" hidden> |
| - Deletes old log |
| - </div> |
| - </if> |
| - </button> |
| - </div> |
| - <div> |
| - <button id="export-view-stop-data" disabled>Stop Logging</button> |
| - </div> |
| - <div> |
| - <if expr="is_ios or is_android"> |
| - <button id="export-view-mobile-send-data" disabled> |
| - Email Log |
| - <div class="warning" id="export-view-mobile-private-data-text" hidden> |
| - Log contains private information |
| - </div> |
| - <div class="warning" id="export-view-mobile-send-old-log-text" hidden> |
| - Log file from previous session |
| - </div> |
| - </button> |
| - </if> |
| + <div id="export-view-state-uninitialized"> |
| + <h2>Network Log Export</h2> |
| + Loading... |
| + </div> |
| + |
| + <div id="export-view-state-initial"> |
| + <h2>Capture Network Log</h2> |
| + <button id="export-view-start-logging">Start Logging to Disk</button> |
| + |
| + <div class="section-container"> |
| + Click the button to start logging future network activity to a file on disk. |
| </div> |
| - <p> |
| - <b>INSTRUCTIONS</b>: Start logging, reproduce the problem, |
| - and then stop logging. |
| - |
| - <if expr="is_ios or is_android"> |
| - Once logging has stopped, click the "Email Log" button to save the |
| - file. Starting a new log will overwrite the old one. |
| - </if> |
| - <if expr="not(is_ios or is_android)"> |
| - Once logging has stopped, attach the log file to the bug report. |
| - </if> |
| - </p> |
| - <p> |
| - <!-- TODO(rayraymond): Change link to that of new standalone webapp. |
| - See http://crbug.com/472699 --> |
| - Log files can be loaded using |
| - <a href="chrome://net-internals#import" target="_blank">net-internals</a>. |
| - </p> |
| - <p> |
| - <b><span class="warning">WARNING</span></b>: Logs contain a list of sites |
| - visited from when logging started to when logging stopped. They may also |
| - contain general network configuration information, such as DNS and proxy |
| - configuration. If private information is not stripped, the logs also |
| - contain cookies and credentials. |
| - </p> |
| - <p> |
| - <b>ADVANCED</b>: |
| + <div class="outline-box"> |
| + <b>OPTIONS</b>: |
| <span class="warning">This section should normally be left alone.</span> |
| <div class="radio-button-div"> |
| <label> |
| <input id="export-view-strip-private-data-button" type="radio" |
| - name="log-mode" value="STRIP_PRIVATE_DATA" checked disabled> |
| + name="log-mode" value="STRIP_PRIVATE_DATA" checked> |
| Strip private information |
| </label> |
| </div> |
| <div class="radio-button-div"> |
| <label> |
| <input id="export-view-include-private-data-button" type="radio" |
| - name="log-mode" value="NORMAL" disabled> |
| + name="log-mode" value="NORMAL"> |
| Include cookies and credentials |
| </label> |
| </div> |
| <div class="radio-button-div"> |
| <label> |
| <input id="export-view-log-bytes-button" type="radio" |
| - name="log-mode" value="LOG_BYTES" disabled> |
| + name="log-mode" value="LOG_BYTES"> |
| Include raw bytes (will include cookies and credentials) |
| </label> |
| </div> |
| - </p> |
| + </div> |
| + |
| + </div> |
| + |
| + <div id="export-view-state-logging"> |
| + <h2>Saving network events to disk...</h2> |
| + |
| + <button id="export-view-stop-logging">Stop Logging</button> |
| + |
| + <div class="section-container"> |
| + <p>Reproduce the network problem now using another tab. When you are |
| + done, return to this page and click the Stop button.</p> |
| + |
| + <p>All of your browser's networking activity will be written to the log |
| + file until you either click the Stop button, or close this tab.</p> |
| + </div> |
| + |
| + <div class="outline-box"> |
| + <b>FILE:</b> <span id='export-view-file-path-logging'></span> <br/> |
| + <b>OPTIONS:</b> <span id="export-view-capture-mode-logging"></span> |
| + </div> |
| + </div> |
| + |
| + <div id="export-view-state-stopped"> |
| + <h2>Log file written</h2> |
| + |
| + <if expr="is_ios or is_android"> |
| + <button id="export-view-mobile-email"> |
| + Email Log |
| + <div class="warning" id="export-view-mobile-private-data-text" hidden> |
| + Log contains private information |
| + </div> |
| + |
| + <div class="warning" id="export-view-mobile-send-old-log-text" hidden> |
| + Log file from previous session |
| + </div> |
| + </button> |
| + </if> |
| + |
| + <button id="export-view-startover"> |
| + Start Over |
| + </button> |
| + |
| + <div class="section-container"> |
| + <if expr="is_ios or is_android"> |
| + Share the log by emailing it, and you are done! |
| + </if> |
| + |
| + <if expr="not(is_ios or is_android)"> |
| + Attach the log file to your bug report, and you are done! |
| + </if> |
| + </div> |
| + |
| + <div class="outline-box"> |
| + <b>FILE:</b> <span id='export-view-file-path-stopped'></span> <br/> |
| + <b>OPTIONS:</b> <span id="export-view-capture-mode-stopped"></span> |
| + </div> |
| + |
| + <div class="section-container"> |
| + <!-- TODO(rayraymond): Change link to that of new standalone webapp. |
| + See http://crbug.com/472699 --> |
| + The log file can also be loaded using |
| + <a href="chrome://net-internals#import" target="_blank">net-internals</a>. |
| + </div> |
| + |
| + <div class="section-container"> |
| + <b><span class="warning">PRIVACY</span></b>: Be aware when |
| + sharing your network logs that they may contain private information. At |
| + a minimum, they list the URLs and hostnames of sites visited while |
| + logging was enabled. |
| + <a href="#" id="export-view-privacy-read-more-link">Read more...</a> |
| + |
| + <div id="export-view-privacy-read-more"> |
| + <ul> |
| + <li>There be some cached hostnames/URLs from sites visited prior |
|
xunjieli
2017/05/02 17:10:01
nit: There be -> There can be ?
eroman
2017/05/02 20:07:58
Done.
|
| + to enabling logging.</li> |
| + <li>Logs may contain information about your networking environment, |
| + such as the proxy configuration used.</li> |
| + <li>The default logging options do a <i>best-effort</i> stripping of |
| + any cookies/credentials in the logged requests.</li> |
| + </ul> |
| + </div> |
| + </div> |
| </div> |
| - <pre id="export-view-file-path-text"></pre> |
| </body> |
| </html> |
