Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/sync/engine_impl/syncer.h

Issue 2850213002: [Sync] Minor refactor around SyncCycle and ModelTypeSet usage. (Closed)
Patch Set: Fix comment grammar. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine_impl/sync_scheduler_impl_unittest.cc ('k') | components/sync/engine_impl/syncer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/syncer.h
diff --git a/components/sync/engine_impl/syncer.h b/components/sync/engine_impl/syncer.h
index 2e86d8e00c18c88c24874deabb8398549984fb7f..455c7590a9c984aca55244361b7bbf6fa20dc5e0 100644
--- a/components/sync/engine_impl/syncer.h
+++ b/components/sync/engine_impl/syncer.h
@@ -58,7 +58,7 @@ class Syncer {
// Returns: false if an error occurred and retries should backoff, true
// otherwise.
virtual bool ConfigureSyncShare(
- ModelTypeSet request_types,
+ const ModelTypeSet& request_types,
sync_pb::GetUpdatesCallerInfo::GetUpdatesSource source,
SyncCycle* cycle);
@@ -85,7 +85,7 @@ class Syncer {
// number of unsynced and ready to commit items reaches zero or an error is
// encountered. A request to exit early will be treated as an error and will
// abort any blocking operations.
- SyncerError BuildAndPostCommits(ModelTypeSet request_types,
+ SyncerError BuildAndPostCommits(const ModelTypeSet& request_types,
NudgeTracker* nudge_tracker,
SyncCycle* cycle,
CommitProcessor* commit_processor);
« no previous file with comments | « components/sync/engine_impl/sync_scheduler_impl_unittest.cc ('k') | components/sync/engine_impl/syncer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698