components/sync/engine_impl/cycle/sync_cycle.cc - Issue 2850213002: [Sync] Minor refactor around SyncCycle and ModelTypeSet usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/cycle/sync_cycle.cc

Issue 2850213002: [Sync] Minor refactor around SyncCycle and ModelTypeSet usage. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/cycle/sync_cycle.cc

diff --git a/components/sync/engine_impl/cycle/sync_cycle.cc b/components/sync/engine_impl/cycle/sync_cycle.cc

index c51eb0fbb37872325207cec6b5a6f998d7fcc412..a8cf9822bed558eee0d5ce8522a5f902a79d4422 100644

--- a/components/sync/engine_impl/cycle/sync_cycle.cc

+++ b/components/sync/engine_impl/cycle/sync_cycle.cc

@@ -13,11 +13,6 @@

namespace syncer {

-// static

-SyncCycle* SyncCycle::Build(SyncCycleContext* context, Delegate* delegate) {

- return new SyncCycle(context, delegate);

SyncCycle::SyncCycle(SyncCycleContext* context, Delegate* delegate)

: context_(context), delegate_(delegate) {

status_controller_ = base::MakeUnique<StatusController>();