Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3620)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

Issue 2850153002: Disable Open in Incognito context item for urls disallowed in Incognito (Closed)
Patch Set: Address feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
index f7c69fc06e4898b368fe4fb096fb492749dfbe77..2998c1163570be23247ac592ba1d7215fae2d893 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
@@ -380,6 +380,18 @@ class RenderViewContextMenuPrefsTest : public ChromeRenderViewHostTestHarness {
return ::CreateContextMenu(web_contents(), registry_.get());
}
+ // Returns a test context menu for a chrome:// url not permitted to open in
+ // incognito mode.
+ std::unique_ptr<TestRenderViewContextMenu> CreateContextMenuOnChromeLink() {
+ content::ContextMenuParams params = CreateParams(MenuItem::LINK);
+ params.unfiltered_link_url = params.link_url = GURL("chrome://settings");
+ std::unique_ptr<TestRenderViewContextMenu> menu(
+ new TestRenderViewContextMenu(web_contents()->GetMainFrame(), params));
+ menu->set_protocol_handler_registry(registry_.get());
+ menu->Init();
+ return menu;
+ }
+
void AppendImageItems(TestRenderViewContextMenu* menu) {
menu->AppendImageItems();
}
@@ -455,6 +467,17 @@ TEST_F(RenderViewContextMenuPrefsTest,
menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
}
+// Verifies Incognito Mode is not enabled for links disallowed in Incognito.
+TEST_F(RenderViewContextMenuPrefsTest,
+ DisableOpenInIncognitoWindowForDisallowedUrls) {
+ std::unique_ptr<TestRenderViewContextMenu> menu(
+ CreateContextMenuOnChromeLink());
+
+ ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
+ EXPECT_FALSE(
+ menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
+}
+
// Make sure the checking custom command id that is not enabled will not
// cause DCHECK failure.
TEST_F(RenderViewContextMenuPrefsTest,
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698