Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 2850153002: Disable Open in Incognito context item for urls disallowed in Incognito (Closed)
Patch Set: Use IsURLAllowedInIncognito function to control link Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 0c8b59878cb0487b0f76db41d1f7a7529cb9040e..881a5203f4e07ffbd02c10ea5b6402451e3a3b31 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -2155,6 +2155,10 @@ bool RenderViewContextMenu::IsOpenLinkOTREnabled() const {
if (browser_context_->IsOffTheRecord() || !params_.link_url.is_valid())
return false;
+ if (!chrome::IsURLAllowedInIncognito(params_.link_url, browser_context_)) {
lazyboy 2017/05/02 23:44:55 nit: drop {}
elawrence 2017/05/03 01:44:47 Done.
+ return false;
+ }
+
IncognitoModePrefs::Availability incognito_avail =
IncognitoModePrefs::GetAvailability(GetPrefs(browser_context_));
return incognito_avail != IncognitoModePrefs::DISABLED;

Powered by Google App Engine
This is Rietveld 408576698