Disable Open in Incognito context item for urls disallowed in Incognito

chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 78 matching lines @@
     ProtocolHandlerRegistry* registry) {
   content::ContextMenuParams params = CreateParams(MenuItem::LINK);
   params.unfiltered_link_url = params.link_url;
   std::unique_ptr<TestRenderViewContextMenu> menu(
       new TestRenderViewContextMenu(web_contents->GetMainFrame(), params));
   menu->set_protocol_handler_registry(registry);
   menu->Init();
   return menu;
 }
 
+// Returns a test context menu for a chrome:// url not permitted to open in
+// incognito mode.
+std::unique_ptr<TestRenderViewContextMenu> CreateContextMenuOnChromeLink(
+    content::WebContents* web_contents,
+    ProtocolHandlerRegistry* registry) {
+  content::ContextMenuParams params = CreateParams(MenuItem::LINK);
+  params.unfiltered_link_url = params.link_url = GURL("chrome://settings");
+  std::unique_ptr<TestRenderViewContextMenu> menu(
+      new TestRenderViewContextMenu(web_contents->GetMainFrame(), params));
+  menu->set_protocol_handler_registry(registry);
+  menu->Init();
+  return menu;
+}
+
 }  // namespace
 
 class RenderViewContextMenuTest : public testing::Test {
  protected:
   RenderViewContextMenuTest() = default;
 
   // Proxy defined here to minimize friend classes in RenderViewContextMenu
   static bool ExtensionContextAndPatternMatch(
       const content::ContextMenuParams& params,
       MenuItem::ContextList contexts,
@@ skipping 264 matching lines @@
 
   void TearDown() override {
     registry_.reset();
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   std::unique_ptr<TestRenderViewContextMenu> CreateContextMenu() {
     return ::CreateContextMenu(web_contents(), registry_.get());
   }
 
+  std::unique_ptr<TestRenderViewContextMenu> CreateContextMenuOnChromeLink() {
+    return ::CreateContextMenuOnChromeLink(web_contents(), registry_.get());

[lazyboy, 2017/05/02 23:44:55]

Is there a reason not to put the implementation right here and extract it to a
separate function in line 101 above?
If not then we should just create the menu instance right here.

[elawrence, 2017/05/03 01:44:47]

Done. 
I was mimic'ing the pattern of CreateContextMenu(w,r) above, but I see now that
the existing code was written that way because it's used in two different test
fixtures. 

+  }
+
   void AppendImageItems(TestRenderViewContextMenu* menu) {
     menu->AppendImageItems();
   }
 
   void SetupDataReductionProxy(bool enable_data_reduction_proxy) {
     drp_test_context_ =
         data_reduction_proxy::DataReductionProxyTestContext::Builder()
             .WithParamsFlags(
                  data_reduction_proxy::DataReductionProxyParams::kPromoAllowed)
             .WithMockConfig()
@@ skipping 55 matching lines @@
 
   // Disable Incognito mode.
   IncognitoModePrefs::SetAvailability(profile()->GetPrefs(),
                                       IncognitoModePrefs::DISABLED);
   menu = CreateContextMenu();
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
   EXPECT_FALSE(
       menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
 }
 
+// Verifies Incognito Mode is not enabled for links disallowed in Incognito.
+TEST_F(RenderViewContextMenuPrefsTest,
+       DisableOpenInIncognitoWindowForChromeUrls) {
+  std::unique_ptr<TestRenderViewContextMenu> menu(
+      CreateContextMenuOnChromeLink());
+
+  ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
+  EXPECT_FALSE(
+      menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD));
+}
+
 // Make sure the checking custom command id that is not enabled will not
 // cause DCHECK failure.
 TEST_F(RenderViewContextMenuPrefsTest,
        IsCustomCommandIdEnabled) {
   std::unique_ptr<TestRenderViewContextMenu> menu(CreateContextMenu());
 
   EXPECT_FALSE(menu->IsCommandIdEnabled(IDC_CONTENT_CONTEXT_CUSTOM_FIRST));
 }
 
 // Verify that request headers specify that data reduction proxy should return
@@ skipping 52 matching lines @@
   params.unfiltered_link_url = params.link_url;
   content::WebContents* wc = web_contents();
   std::unique_ptr<TestRenderViewContextMenu> menu(
       new TestRenderViewContextMenu(wc->GetMainFrame(), params));
   AppendImageItems(menu.get());
 
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_LOAD_ORIGINAL_IMAGE));
 
   DestroyDataReductionProxySettings();
 }