Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/dom/DocumentOrderedList.h

Issue 2850133003: Remove checks added to DocumentOrderList for crbug.com/699269 diagnosis (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DocumentOrderedList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/DocumentOrderedList.h
diff --git a/third_party/WebKit/Source/core/dom/DocumentOrderedList.h b/third_party/WebKit/Source/core/dom/DocumentOrderedList.h
index 24c2f8fbfdf563e3676cb2e870c33cbe4cb33d3b..540c3d4335d43ce485122ff449bb49fd8981780f 100644
--- a/third_party/WebKit/Source/core/dom/DocumentOrderedList.h
+++ b/third_party/WebKit/Source/core/dom/DocumentOrderedList.h
@@ -42,32 +42,12 @@ class DocumentOrderedList final {
DISALLOW_NEW();
public:
- DocumentOrderedList() : mutation_forbidden_(false) {}
-
- // Forbids changes to DocumentOrderedList. Used to check if we are
- // unintentionally changing DocumentOrderedList while iterating. Added for
- // crbug.com/699269 diagnosis.
- class MutationForbiddenScope final {
- STACK_ALLOCATED();
-
- public:
- explicit MutationForbiddenScope(DocumentOrderedList* list) : list_(list) {
- list_->mutation_forbidden_ = true;
- }
- ~MutationForbiddenScope() { list_->mutation_forbidden_ = false; }
-
- private:
- DocumentOrderedList* list_;
- };
+ DocumentOrderedList() {}
void Add(Node*);
void Remove(const Node*);
bool IsEmpty() const { return nodes_.IsEmpty(); }
- void Clear() {
- // TODO(keishi): CHECK() added for crbug.com/699269 diagnosis.
- CHECK(!mutation_forbidden_);
- nodes_.clear();
- }
+ void Clear() { nodes_.clear(); }
size_t size() const { return nodes_.size(); }
using iterator = HeapListHashSet<Member<Node>, 32>::iterator;
@@ -87,7 +67,6 @@ class DocumentOrderedList final {
private:
HeapListHashSet<Member<Node>, 32> nodes_;
- bool mutation_forbidden_;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/DocumentOrderedList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698