Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: net/ssl/client_cert_store_unittest-inl.h

Issue 2850083002: Disable 2 flaky tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SSL_CLIENT_CERT_STORE_UNITTEST_INL_H_ 5 #ifndef NET_SSL_CLIENT_CERT_STORE_UNITTEST_INL_H_
6 #define NET_SSL_CLIENT_CERT_STORE_UNITTEST_INL_H_ 6 #define NET_SSL_CLIENT_CERT_STORE_UNITTEST_INL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 std::vector<scoped_refptr<X509Certificate> > selected_certs; 86 std::vector<scoped_refptr<X509Certificate> > selected_certs;
87 bool rv = this->delegate_.SelectClientCerts( 87 bool rv = this->delegate_.SelectClientCerts(
88 certs, *request.get(), &selected_certs); 88 certs, *request.get(), &selected_certs);
89 EXPECT_TRUE(rv); 89 EXPECT_TRUE(rv);
90 ASSERT_EQ(1u, selected_certs.size()); 90 ASSERT_EQ(1u, selected_certs.size());
91 EXPECT_TRUE(selected_certs[0]->Equals(cert.get())); 91 EXPECT_TRUE(selected_certs[0]->Equals(cert.get()));
92 } 92 }
93 93
94 // Verify that certificates are correctly filtered against CertRequestInfo with 94 // Verify that certificates are correctly filtered against CertRequestInfo with
95 // |cert_authorities| containing only |authority_1_DN|. 95 // |cert_authorities| containing only |authority_1_DN|.
96 TYPED_TEST_P(ClientCertStoreTest, CertAuthorityFiltering) { 96 // Flaky: https://crbug.com/716730
97 TYPED_TEST_P(ClientCertStoreTest, DISABLED_CertAuthorityFiltering) {
97 scoped_refptr<X509Certificate> cert_1( 98 scoped_refptr<X509Certificate> cert_1(
98 ImportCertFromFile(GetTestCertsDirectory(), "client_1.pem")); 99 ImportCertFromFile(GetTestCertsDirectory(), "client_1.pem"));
99 ASSERT_TRUE(cert_1.get()); 100 ASSERT_TRUE(cert_1.get());
100 scoped_refptr<X509Certificate> cert_2( 101 scoped_refptr<X509Certificate> cert_2(
101 ImportCertFromFile(GetTestCertsDirectory(), "client_2.pem")); 102 ImportCertFromFile(GetTestCertsDirectory(), "client_2.pem"));
102 ASSERT_TRUE(cert_2.get()); 103 ASSERT_TRUE(cert_2.get());
103 104
104 std::vector<std::string> authority_1( 105 std::vector<std::string> authority_1(
105 1, std::string(reinterpret_cast<const char*>(kAuthority1DN), 106 1, std::string(reinterpret_cast<const char*>(kAuthority1DN),
106 sizeof(kAuthority1DN))); 107 sizeof(kAuthority1DN)));
(...skipping 15 matching lines...) Expand all
122 bool rv = this->delegate_.SelectClientCerts( 123 bool rv = this->delegate_.SelectClientCerts(
123 certs, *request.get(), &selected_certs); 124 certs, *request.get(), &selected_certs);
124 EXPECT_TRUE(rv); 125 EXPECT_TRUE(rv);
125 ASSERT_EQ(1u, selected_certs.size()); 126 ASSERT_EQ(1u, selected_certs.size());
126 EXPECT_TRUE(selected_certs[0]->Equals(cert_1.get())); 127 EXPECT_TRUE(selected_certs[0]->Equals(cert_1.get()));
127 } 128 }
128 129
129 REGISTER_TYPED_TEST_CASE_P(ClientCertStoreTest, 130 REGISTER_TYPED_TEST_CASE_P(ClientCertStoreTest,
130 EmptyQuery, 131 EmptyQuery,
131 AllIssuersAllowed, 132 AllIssuersAllowed,
132 CertAuthorityFiltering); 133 DISABLED_CertAuthorityFiltering);
133 134
134 } // namespace net 135 } // namespace net
135 136
136 #endif // NET_SSL_CLIENT_CERT_STORE_UNITTEST_INL_H_ 137 #endif // NET_SSL_CLIENT_CERT_STORE_UNITTEST_INL_H_
OLDNEW
« no previous file with comments | « chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698