Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 285008: If chrome starts without a network connection, the sync serverconnectionmanag... (Closed)

Created:
11 years, 2 months ago by tim (not reviewing)
Modified:
9 years, 6 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana
Visibility:
Public.

Description

If chrome starts without a network connection, the sync serverconnectionmanager won't get an auth_token set until the Authenticator validates it. We had a bug where when we come online and the server connection manager determines that a server is reachable, we would drop the request to authenticate (which is the first step in getting the auth token set properly). This was resulting in subsequent requests returning 401 UNAUTHORIZED, and sync getting stuck in an offline state. The fix is to set the auth token on startup, so the gaia authenticator and server connection manager start off on the same page. BUG=24973 TEST=setup sync, shutdown chrome. ipconfig /release, start chrome, ipconfig /renew. about:sync shoudl show 'READY'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29350

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/sync/engine/syncapi.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tim (not reviewing)
New snapshot up.
11 years, 2 months ago (2009-10-16 22:37:33 UTC) #1
ncarter (slow)
11 years, 2 months ago (2009-10-16 22:39:26 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698