Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4289)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java

Issue 2850063002: ❄ Split off RadioButtonLayout from InfoBarControls (Closed)
Patch Set: Fix again Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java b/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
index 4720f22b5db7e4a60f7cca4b38be9a059df3c047..57ca1320d998778dafb2ab88f11d2851db276705 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
@@ -9,17 +9,18 @@ import android.content.DialogInterface;
import android.os.Bundle;
import android.support.annotation.Nullable;
import android.view.View;
+import android.widget.Button;
import android.widget.RadioGroup;
import android.widget.RadioGroup.OnCheckedChangeListener;
import org.chromium.base.Callback;
import org.chromium.base.library_loader.LibraryLoader;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.infobar.InfoBarControlLayout;
import org.chromium.chrome.browser.locale.LocaleManager.SearchEnginePromoType;
import org.chromium.chrome.browser.search_engines.TemplateUrlService;
import org.chromium.chrome.browser.search_engines.TemplateUrlService.TemplateUrl;
import org.chromium.chrome.browser.widget.PromoDialog;
+import org.chromium.chrome.browser.widget.RadioButtonLayout;
import java.util.ArrayList;
import java.util.Collections;
@@ -108,10 +109,13 @@ public class DefaultSearchEnginePromoDialog extends PromoDialog implements OnChe
}
// Add the search engines to the dialog.
- InfoBarControlLayout controls = addControlLayout();
- mRadioGroup = controls.addRadioButtons(
- engineNames, engineKeywords, InfoBarControlLayout.INVALID_INDEX);
- mRadioGroup.setOnCheckedChangeListener(this);
+ RadioButtonLayout radioButtons = new RadioButtonLayout(getContext());
+ radioButtons.addOptions(engineNames, engineKeywords);
+ radioButtons.setOnCheckedChangeListener(this);
+ addControl(radioButtons);
+
+ Button button = (Button) findViewById(R.id.button_primary);
+ button.setOnClickListener(this);
updateButtonState();
}

Powered by Google App Engine
This is Rietveld 408576698