❄ Split off RadioButtonLayout from InfoBarControls

chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarControlLayout.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.infobar;
 
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Paint;
 import android.support.annotation.Nullable;
 import android.support.v7.widget.SwitchCompat;
 import android.text.method.LinkMovementMethod;
+import android.util.AttributeSet;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.ArrayAdapter;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
-import android.widget.RadioButton;
-import android.widget.RadioGroup;
 import android.widget.RatingBar;
 import android.widget.Spinner;
 import android.widget.TextView;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.widget.DualControlLayout;
+import org.chromium.chrome.browser.widget.RadioButtonLayout;
 
 import java.util.List;
 
 /**
  * Lays out a group of controls (e.g. switches, spinners, or additional text) for InfoBars that need
  * more than the normal pair of buttons.
  *
  * This class works with the {@link InfoBarLayout} to define a standard set of controls with
  * standardized spacings and text styling that gets laid out in grid form: https://crbug.com/543205
  *
  * Manually specified margins on the children managed by this layout are EXPLICITLY ignored to
  * enforce a uniform margin between controls across all InfoBar types.  Do NOT circumvent this
  * restriction with creative layout definitions.  If the layout algorithm doesn't work for your new
  * InfoBar, convince Chrome for Android's UX team to amend the master spec and then change the
  * layout algorithm to match.
  *
  * TODO(dfalcantara): The line spacing multiplier is applied to all lines in JB & KK, even if the
  *                    TextView has only one line.  This throws off vertical alignment.  Find a
  *                    solution that hopefully doesn't involve subclassing the TextView.
- *
- * TODO(dfalcantara): Move this to a more general location.
  */
 public final class InfoBarControlLayout extends ViewGroup {
-    public static final int INVALID_INDEX = -1;
-
     /**
      * ArrayAdapter that automatically determines what size make its Views to accommodate all of
      * its potential values.
      * @param <T> Type of object that the ArrayAdapter stores.
      */
     public static final class InfoBarArrayAdapter<T> extends ArrayAdapter<T> {
         private final String mLabel;
         private int mMinWidthRequiredForValues;
 
         public InfoBarArrayAdapter(Context context, String label) {
@@ skipping 92 matching lines @@
         }
     }
 
     private final int mMarginBetweenRows;
     private final int mMarginBetweenColumns;
 
     /**
      * Do not call this method directly; use {@link InfoBarLayout#addControlLayout()}.
      */
     public InfoBarControlLayout(Context context) {
-        super(context);
+        this(context, null);
+    }
+
+    public InfoBarControlLayout(Context context, AttributeSet attrs) {
+        super(context, attrs);
 
         Resources resources = context.getResources();
         mMarginBetweenRows =
                 resources.getDimensionPixelSize(R.dimen.infobar_control_margin_between_rows);
         mMarginBetweenColumns =
                 resources.getDimensionPixelSize(R.dimen.infobar_control_margin_between_columns);
     }
 
     @Override
     protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) {
@@ skipping 177 matching lines @@
                 (SwitchCompat) switchLayout.findViewById(R.id.control_toggle_switch);
         switchView.setId(toggleId);
         switchView.setChecked(isChecked);
 
         return switchLayout;
     }
 
     /**
      * Creates a set of standard radio buttons and adds it to the layout.
      *
-     * -------------------------------------------------
-     * | O | MESSAGE #1                                |
-     * | O | MESSAGE #N                                |
-     * -------------------------------------------------
-     *
      * @param messages      Messages to display for the options.
      * @param tags          Optional list of tags to attach to the buttons.
-     * @param selectedIndex Which index to mark as being selected.
      */
-    public RadioGroup addRadioButtons(
-            List<CharSequence> messages, @Nullable List<?> tags, int selectedIndex) {
-        if (tags != null) assert tags.size() == messages.size();
-
+    public RadioButtonLayout addRadioButtons(List<CharSequence> messages, @Nullable List<?> tags) {
         ControlLayoutParams params = new ControlLayoutParams();
         params.mMustBeFullWidth = true;
 
-        RadioGroup radioLayout = new RadioGroup(getContext());
+        RadioButtonLayout radioLayout = new RadioButtonLayout(getContext());
+        radioLayout.addOptions(messages, tags);
+
         addView(radioLayout, params);
-
-        for (int i = 0; i < messages.size(); i++) {
-            RadioButton button =
-                    (RadioButton) LayoutInflater.from(getContext())
-                            .inflate(R.layout.infobar_control_radio, radioLayout, false);
-            button.setText(messages.get(i));
-            if (tags != null) button.setTag(tags.get(i));
-            button.setChecked(i == selectedIndex);
-            radioLayout.addView(button);
-
-            // Add margins between each of the radio buttons.
-            if (i < messages.size() - 1) {
-                ((MarginLayoutParams) button.getLayoutParams()).bottomMargin = mMarginBetweenRows;
-            }
-        }
-
         return radioLayout;
     }
 
     /**
      * Creates a standard spinner and adds it to the layout.
      */
     public <T> Spinner addSpinner(int spinnerId, ArrayAdapter<T> arrayAdapter) {
         Spinner spinner = (Spinner) LayoutInflater.from(getContext()).inflate(
                 R.layout.infobar_control_spinner, this, false);
         spinner.setAdapter(arrayAdapter);
@@ skipping 54 matching lines @@
 
     /**
      * @return The {@link ControlLayoutParams} for the given child.
      */
     @VisibleForTesting
     static ControlLayoutParams getControlLayoutParams(View child) {
         return (ControlLayoutParams) child.getLayoutParams();
     }
 
 }