Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1895)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/shell_integration.h

Issue 2850042: Deprecate more old filepath functions. (Closed)
Patch Set: rebase Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/download/download_manager.cc ('K') | « chrome/browser/printing/printing_layout_uitest.cc ('k') | chrome/browser/shell_integration.cc » ('j') | chrome/browser/shell_integration.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/shell_integration.h
diff --git a/chrome/browser/shell_integration.h b/chrome/browser/shell_integration.h
index 670063e0ba06d0273df28154cad918992c69feef..fbdf32e85e39cdcb2954394585887fc49e828f04 100644
--- a/chrome/browser/shell_integration.h
+++ b/chrome/browser/shell_integration.h
@@ -71,6 +71,8 @@ class ShellIntegration {
// which is deprecated. If |extension_app_id| is non-empty, an arguments
// string is created using the kAppId=<id> flag. Otherwise, the kApp=<url> is
// used.
+ // XXX This function is dangerous, do not use! You cannot treat
Nico 2010/07/08 17:37:28 If you want to check this in, s/XXX/NOTE/
+ // command lines as plain strings as there are metacharacters.
static std::string GetCommandLineArgumentsCommon(const GURL& url,
const string16& extension_app_id);
« chrome/browser/download/download_manager.cc ('K') | « chrome/browser/printing/printing_layout_uitest.cc ('k') | chrome/browser/shell_integration.cc » ('j') | chrome/browser/shell_integration.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698