Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: net/quic/chromium/crypto/proof_verifier_chromium.cc

Issue 2850033002: Check Expect-CT at connection setup (Closed)
Patch Set: mattm comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/chromium/crypto/proof_verifier_chromium.cc b/net/quic/chromium/crypto/proof_verifier_chromium.cc
index 95b1999061827fbb4ae003456e9f864cd7a4a964..fb4ea9141e142c47d0e9ffb495e05fc6f2a4f1b7 100644
--- a/net/quic/chromium/crypto/proof_verifier_chromium.cc
+++ b/net/quic/chromium/crypto/proof_verifier_chromium.cc
@@ -420,13 +420,14 @@ int ProofVerifierChromium::Job::DoVerifyCertComplete(int result) {
cert_verify_result.verified_cert.get(), verified_scts, net_log_);
int ct_result = OK;
- if (verify_details_->ct_verify_result.cert_policy_compliance !=
- ct::CertPolicyCompliance::CERT_POLICY_COMPLIES_VIA_SCTS &&
- verify_details_->ct_verify_result.cert_policy_compliance !=
- ct::CertPolicyCompliance::CERT_POLICY_BUILD_NOT_TIMELY &&
- transport_security_state_->ShouldRequireCT(
- hostname_, cert_verify_result.verified_cert.get(),
- cert_verify_result.public_key_hashes)) {
+ if (!transport_security_state_->CheckCTRequirements(
+ HostPortPair(hostname_, port_),
+ cert_verify_result.is_issued_by_known_root,
+ cert_verify_result.public_key_hashes,
+ cert_verify_result.verified_cert.get(), cert_.get(),
+ verify_details_->ct_verify_result.scts,
+ TransportSecurityState::ENABLE_EXPECT_CT_REPORTS,
+ verify_details_->ct_verify_result.cert_policy_compliance)) {
verify_details_->cert_verify_result.cert_status |=
CERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED;
ct_result = ERR_CERTIFICATE_TRANSPARENCY_REQUIRED;

Powered by Google App Engine
This is Rietveld 408576698