Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7521)

Unified Diff: chrome/test/startup/shutdown_test.cc

Issue 2850006: Mark several tabs as flaky and ignore on mac. (Closed)
Patch Set: Change startup tests to use 10 tabs instead of 20 Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/startup/startup_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/startup/shutdown_test.cc
diff --git a/chrome/test/startup/shutdown_test.cc b/chrome/test/startup/shutdown_test.cc
index bd739fbe31c94a38c374000ab723df75cfe9ffdb..9f38cff2886a8af058ccb969fdcd2fb9c4e4a481 100644
--- a/chrome/test/startup/shutdown_test.cc
+++ b/chrome/test/startup/shutdown_test.cc
@@ -109,13 +109,22 @@ TEST_F(ShutdownTest, SimpleSessionEnding) {
true, /* important */ UITest::SESSION_ENDING);
}
-TEST_F(ShutdownTest, TwentyTabsWindowClose) {
+// http://crbug.com/46609
+#if defined(OS_MACOSX)
+#define MAYBE_TwentyTabsWindowClose FLAKY_TwentyTabsWindowClose
+#define MAYBE_TwentyTabsUserQuit FLAKY_TwentyTabsUserQuit
+#else
+#define MAYBE_TwentyTabsWindowClose TwentyTabsWindowClose
+#define MAYBE_TwentyTabsUserQuit TwentyTabsUserQuit
+#endif
+
+TEST_F(ShutdownTest, MAYBE_TwentyTabsWindowClose) {
SetUpTwentyTabs();
RunShutdownTest("shutdown", "twentytabs-window-close",
true, /* important */ UITest::WINDOW_CLOSE);
}
-TEST_F(ShutdownTest, TwentyTabsUserQuit) {
+TEST_F(ShutdownTest, MAYBE_TwentyTabsUserQuit) {
SetUpTwentyTabs();
RunShutdownTest("shutdown", "twentytabs-user-quit",
true, /* important */ UITest::USER_QUIT);
@@ -124,9 +133,13 @@ TEST_F(ShutdownTest, TwentyTabsUserQuit) {
// http://crbug.com/40671
#if defined(OS_WIN) && !defined(NDEBUG)
#define MAYBE_TwentyTabsSessionEnding DISABLED_TwentyTabsSessionEnding
+#elif defined(OS_MACOSX)
+// http://crbug.com/46609
+#define MAYBE_TwentyTabsSessionEnding FLAKY_TwentyTabsSessionEnding
#else
#define MAYBE_TwentyTabsSessionEnding TwentyTabsSessionEnding
#endif
+
TEST_F(ShutdownTest, MAYBE_TwentyTabsSessionEnding) {
SetUpTwentyTabs();
RunShutdownTest("shutdown", "twentytabs-session-ending",
« no previous file with comments | « no previous file | chrome/test/startup/startup_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698