Chromium Code Reviews
Help | Chromium Project | Sign in
(26)

Issue 2850006: Mark several tabs as flaky and ignore on mac. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Patrick Horn
Modified:
4 years ago
Reviewers:
michaeln, Lei Zhang, huanr
CC:
chromium-reviews, Paweł Hajdan Jr., TVL
Visibility:
Public.

Description

Mark StartupTests.Perf*SeveralTabs and ShutdownTests.*TwentyTabs* as flaky on mac. BUG=46609 TEST=startup_tests don't fail on mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50018

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Mark tests flaky instead of disabling. Added ShutdownTest.TwentyTabs* as well. #

Patch Set 4 : Use MAYBE for mac to avoid marking flaky for other os's #

Patch Set 5 : Change startup tests to use 10 tabs instead of 20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M chrome/test/startup/shutdown_test.cc View 3 2 chunks +15 lines, -2 lines 0 comments Download
M chrome/test/startup/startup_test.cc View 1 2 3 4 1 chunk +15 lines, -6 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
michaeln
LGTM http://codereview.chromium.org/2850006/diff/2001/3001 File chrome/test/startup/startup_test.cc (right): http://codereview.chromium.org/2850006/diff/2001/3001#newcode201 chrome/test/startup/startup_test.cc:201: #if !defined(OS_MACOSX) It looks like they sometimes pass ...
4 years, 11 months ago (2010-06-15 21:59:08 UTC) #1
Patrick Horn
The twenty tabs tests are randomly failing on 10.6. This patch marks them as flaky ...
4 years, 11 months ago (2010-06-15 23:05:02 UTC) #2
Lei Zhang
If it's only failing on OS_X and not other platforms, then you should do: #if ...
4 years, 11 months ago (2010-06-15 23:11:59 UTC) #3
Patrick Horn
Changed FLAKY to MAYBE and added ifdefs to make them flaky only on mac. Do ...
4 years, 11 months ago (2010-06-15 23:50:32 UTC) #4
Patrick Horn
I changed the startup tests to use 10 tabs instead of 20 since they are ...
4 years, 11 months ago (2010-06-16 19:40:46 UTC) #5
huanr
4 years, 11 months ago (2010-06-16 19:43:35 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be