Mark several tabs as flaky and ignore on mac.

Mark StartupTests.Perf*SeveralTabs and ShutdownTests.*TwentyTabs* as flaky on mac.

BUG=46609
TEST=startup_tests don't fail on mac

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50018

[michaeln, 2010-06-15 21:59:08]

LGTM

http://codereview.chromium.org/2850006/diff/2001/3001
File chrome/test/startup/startup_test.cc (right):

http://codereview.chromium.org/2850006/diff/2001/3001#newcode201
chrome/test/startup/startup_test.cc:201: #if !defined(OS_MACOSX)
It looks like they sometimes pass on macosx as well. If they pass more often
than not on macosx, marking as FLAKY probably would be better?

Maybe open a bug to fix things for real too.

[Patrick Horn, 2010-06-15 23:05:02]

The twenty tabs tests are randomly failing on 10.6. This patch marks them as
flaky until we understand the problem.

http://codereview.chromium.org/2850006/diff/2001/3001
File chrome/test/startup/startup_test.cc (right):

http://codereview.chromium.org/2850006/diff/2001/3001#newcode201
chrome/test/startup/startup_test.cc:201: #if !defined(OS_MACOSX)
On 2010/06/15 21:59:08, michaeln wrote:
> It looks like they sometimes pass on macosx as well. If they pass more often
> than not on macosx, marking as FLAKY probably would be better?
> 
> Maybe open a bug to fix things for real too.

Opened http://crbug.com/46609

Marking them flaky for all platforms for now, in addition to shutdown tests
which are also flaky on 10.6.

[Lei Zhang, 2010-06-15 23:11:59]

If it's only failing on OS_X and not other platforms, then you should do:

#if defined(OS_MACOSX)
#define MAYBE_TestFoo FLAKY_TestFoo
#else
#define MAYBE_TestFoo TestFoo
#endif

TEST_F(ShutdownTest, MAYBE_TestFoo)
...


so the test is only marked flaky on OS X and not on other platforms.

[Patrick Horn, 2010-06-15 23:50:32]

Changed FLAKY to MAYBE and added ifdefs to make them flaky only on mac. Do the
ifdefs look right?

[Patrick Horn, 2010-06-16 19:40:46]

I changed the startup tests to use 10 tabs instead of 20 since they are
relatively new anyway. The overall problem is that we are starting 10 or 20 tabs
at once, and while most of the time it's fine, a small percentage of the time,
the tabs all stack together and cause contention or something of that sort. If
someone checks this over and lgtm's it, I can check it in.

[huanr, 2010-06-16 19:43:35]

LGTM