Add flag to override Effective Connection Type

net/nqe/network_quality_estimator_params.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/nqe/network_quality_estimator_params.h"
 
 #include <stdint.h>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/time/time.h"
@@ skipping 48 matching lines @@
   const auto it = params.find(parameter_name);
   if (it == params.end())
     return default_value;
   return it->second;
 }
 
 }  // namespace
 
 namespace net {
 
+const char kForceEffectiveConnectionType[] = "force_effective_connection_type";
+
 namespace nqe {
 
 namespace internal {
 
 NetworkQualityEstimatorParams::NetworkQualityEstimatorParams(
     const std::map<std::string, std::string>& params)
     : params_(params) {}
 
 NetworkQualityEstimatorParams::~NetworkQualityEstimatorParams() {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ skipping 277 matching lines @@
       GetDoubleValueForVariationParamWithDefaultValue(
           params_, "correlation_logging_probability", 0.01);
   DCHECK_LE(0.0, correlation_uma_logging_probability);
   DCHECK_GE(1.0, correlation_uma_logging_probability);
   return correlation_uma_logging_probability;
 }
 
 bool NetworkQualityEstimatorParams::forced_effective_connection_type_set()
     const {
   return !GetStringValueForVariationParamWithDefaultValue(
-              params_, "force_effective_connection_type", "")
+              params_, kForceEffectiveConnectionType, "")
               .empty();
 }
 
 EffectiveConnectionType
 NetworkQualityEstimatorParams::forced_effective_connection_type() const {
   EffectiveConnectionType forced_effective_connection_type =
       EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
   std::string forced_value = GetStringValueForVariationParamWithDefaultValue(
-      params_, "force_effective_connection_type",
+      params_, kForceEffectiveConnectionType,
       GetNameForEffectiveConnectionType(EFFECTIVE_CONNECTION_TYPE_UNKNOWN));
   DCHECK(!forced_value.empty());
   bool effective_connection_type_available = GetEffectiveConnectionTypeForName(
       forced_value, &forced_effective_connection_type);
   DCHECK(effective_connection_type_available);
 
   // Silence unused variable warning in release builds.
   (void)effective_connection_type_available;
 
   return forced_effective_connection_type;
@@ skipping 16 matching lines @@
   // Use 1000 milliseconds as the default value.
   return base::TimeDelta::FromMilliseconds(GetValueForVariationParam(
       params_, "min_socket_watcher_notification_interval_msec", 1000));
 }
 
 }  // namespace internal
 
 }  // namespace nqe
 
 }  // namespace net