Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: net/spdy/core/lifo_write_scheduler.h

Issue 2849983002: Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/core/lifo_write_scheduler_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/core/lifo_write_scheduler.h
diff --git a/net/spdy/core/lifo_write_scheduler.h b/net/spdy/core/lifo_write_scheduler.h
index 29747dfb994eb95837eed44fd5e148c8287c28c1..f66b81883046a1cb673597cbfe04d5b05cdfbb6d 100644
--- a/net/spdy/core/lifo_write_scheduler.h
+++ b/net/spdy/core/lifo_write_scheduler.h
@@ -69,7 +69,8 @@
}
bool ShouldYield(StreamIdType stream_id) const override {
- return !ready_streams_.empty() && stream_id < *ready_streams_.rbegin();
+ // stream_id is not necessary to be on the ready list.
+ return stream_id < *ready_streams_.rbegin();
}
void MarkStreamReady(StreamIdType stream_id, bool /*add_to_front*/) override;
@@ -105,7 +106,6 @@
return;
}
registered_streams_.erase(stream_id);
- ready_streams_.erase(stream_id);
}
template <typename StreamIdType>
@@ -161,7 +161,7 @@
return;
}
if (ready_streams_.find(stream_id) != ready_streams_.end()) {
- VLOG(1) << "Stream already exists in the list";
+ SPDY_BUG << "Stream already exists in the list";
return;
}
ready_streams_.insert(stream_id);
@@ -172,7 +172,7 @@
StreamIdType stream_id) {
auto it = ready_streams_.find(stream_id);
if (it == ready_streams_.end()) {
- VLOG(1) << "Try to remove a stream that is not on list";
+ SPDY_BUG << "Try to remove a stream that is not on list";
return;
}
ready_streams_.erase(it);
« no previous file with comments | « no previous file | net/spdy/core/lifo_write_scheduler_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698