Use the task scheduler for blocking tasks in the USB service on Linux

device/usb/usb_device_handle_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/usb/usb_device_handle.h"
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/scoped_task_environment.h"
 #include "base/test/test_io_thread.h"
 #include "device/test/test_device_client.h"
 #include "device/test/usb_test_gadget.h"
 #include "device/usb/usb_device.h"
 #include "net/base/io_buffer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace device {
 
 namespace {
 
 class UsbDeviceHandleTest : public ::testing::Test {
  public:
-  void SetUp() override {
-    message_loop_.reset(new base::MessageLoopForUI);
-    io_thread_.reset(new base::TestIOThread(base::TestIOThread::kAutoStart));
-    device_client_.reset(new TestDeviceClient(io_thread_->task_runner()));
-  }
+  UsbDeviceHandleTest()
+      : io_thread_(base::TestIOThread::kAutoStart),
+        scoped_task_environment_(
+            base::test::ScopedTaskEnvironment::MainThreadType::UI),
+        device_client_(io_thread_.task_runner()) {}
 
  protected:
-  std::unique_ptr<base::TestIOThread> io_thread_;
+  base::TestIOThread io_thread_;
 
  private:
-  std::unique_ptr<base::MessageLoop> message_loop_;
-  std::unique_ptr<TestDeviceClient> device_client_;
+  base::test::ScopedTaskEnvironment scoped_task_environment_;
+  TestDeviceClient device_client_;
 };
 
 class TestOpenCallback {
  public:
   TestOpenCallback()
       : callback_(
             base::Bind(&TestOpenCallback::SetResult, base::Unretained(this))) {}
 
   scoped_refptr<UsbDeviceHandle> WaitForResult() {
     run_loop_.Run();
@@ skipping 75 matching lines @@
   handle->Close();
   quit_closure.Run();
 }
 
 TEST_F(UsbDeviceHandleTest, InterruptTransfer) {
   if (!UsbTestGadget::IsTestEnabled()) {
     return;
   }
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(0, claim_interface.callback());
@@ skipping 47 matching lines @@
 
   handle->Close();
 }
 
 TEST_F(UsbDeviceHandleTest, BulkTransfer) {
   if (!UsbTestGadget::IsTestEnabled()) {
     return;
   }
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(1, claim_interface.callback());
@@ skipping 47 matching lines @@
   ASSERT_TRUE(release_interface.WaitForResult());
 
   handle->Close();
 }
 
 TEST_F(UsbDeviceHandleTest, ControlTransfer) {
   if (!UsbTestGadget::IsTestEnabled())
     return;
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   scoped_refptr<net::IOBufferWithSize> buffer(new net::IOBufferWithSize(255));
   TestCompletionCallback completion;
   handle->ControlTransfer(
@@ skipping 11 matching lines @@
 
   handle->Close();
 }
 
 TEST_F(UsbDeviceHandleTest, SetInterfaceAlternateSetting) {
   if (!UsbTestGadget::IsTestEnabled()) {
     return;
   }
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(2, claim_interface.callback());
   ASSERT_TRUE(claim_interface.WaitForResult());
 
   TestResultCallback set_interface;
   handle->SetInterfaceAlternateSetting(2, 1, set_interface.callback());
   ASSERT_TRUE(set_interface.WaitForResult());
 
   TestResultCallback release_interface;
   handle->ReleaseInterface(2, release_interface.callback());
   ASSERT_TRUE(release_interface.WaitForResult());
 
   handle->Close();
 }
 
 TEST_F(UsbDeviceHandleTest, CancelOnClose) {
   if (!UsbTestGadget::IsTestEnabled()) {
     return;
   }
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(1, claim_interface.callback());
@@ skipping 10 matching lines @@
   completion.WaitForResult();
   ASSERT_EQ(UsbTransferStatus::CANCELLED, completion.status());
 }
 
 TEST_F(UsbDeviceHandleTest, CancelOnDisconnect) {
   if (!UsbTestGadget::IsTestEnabled()) {
     return;
   }
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(1, claim_interface.callback());
@@ skipping 12 matching lines @@
 
   handle->Close();
 }
 
 TEST_F(UsbDeviceHandleTest, Timeout) {
   if (!UsbTestGadget::IsTestEnabled()) {
     return;
   }
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(1, claim_interface.callback());
@@ skipping 10 matching lines @@
   ASSERT_EQ(UsbTransferStatus::TIMEOUT, completion.status());
 
   handle->Close();
 }
 
 TEST_F(UsbDeviceHandleTest, CloseReentrancy) {
   if (!UsbTestGadget::IsTestEnabled())
     return;
 
   std::unique_ptr<UsbTestGadget> gadget =
-      UsbTestGadget::Claim(io_thread_->task_runner());
+      UsbTestGadget::Claim(io_thread_.task_runner());
   ASSERT_TRUE(gadget.get());
   ASSERT_TRUE(gadget->SetType(UsbTestGadget::ECHO));
 
   TestOpenCallback open_device;
   gadget->GetDevice()->Open(open_device.callback());
   scoped_refptr<UsbDeviceHandle> handle = open_device.WaitForResult();
   ASSERT_TRUE(handle.get());
 
   TestResultCallback claim_interface;
   handle->ClaimInterface(1, claim_interface.callback());
   ASSERT_TRUE(claim_interface.WaitForResult());
 
   base::RunLoop run_loop;
   auto buffer = base::MakeShared<net::IOBufferWithSize>(512);
   handle->GenericTransfer(
       UsbTransferDirection::INBOUND, 0x82, buffer.get(), buffer->size(),
       10,  // 10 millisecond timeout
       base::Bind(&ExpectTimeoutAndClose, handle, run_loop.QuitClosure()));
   // Drop handle so that the completion callback holds the last reference.
   handle = nullptr;
   run_loop.Run();
 }
 
 }  // namespace
 
 }  // namespace device