device/usb/usb_descriptors.cc - Issue 2849893003: Shorten USB enumeration control transfer timeouts to 2 seconds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_descriptors.cc

Issue 2849893003: Shorten USB enumeration control transfer timeouts to 2 seconds (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/usb/usb_descriptors.cc

diff --git a/device/usb/usb_descriptors.cc b/device/usb/usb_descriptors.cc

index 645ee5631547d2b89ee0acdc7d75968532e8728d..dd4b94d931bce78c5666af5c1d675f5334aa793f 100644

--- a/device/usb/usb_descriptors.cc

+++ b/device/usb/usb_descriptors.cc

@@ -41,7 +41,7 @@ const uint8_t kInterfaceDescriptorLength = 9;

const uint8_t kEndpointDescriptorLength = 7;

const uint8_t kInterfaceAssociationDescriptorLength = 8;

-const int kControlTransferTimeout = 60000; // 1 minute

+const int kControlTransferTimeout = 2000; // 2 seconds

mcasas 2017/04/29 01:33:16 nit: consider encoding the units in the name, e.g.

struct UsbInterfaceAssociationDescriptor {

UsbInterfaceAssociationDescriptor(uint8_t first_interface,

« no previous file with comments | « no previous file | device/usb/webusb_descriptors.cc » ('j') | no next file with comments »