Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2849893002: Set 'enclosingElement' for FunctionElementImpl_forLUB. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set 'enclosingElement' for FunctionElementImpl_forLUB. This makes almost all <unknown> library names to go away in front_end inference tests. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f0e1add54240cb65084935f010d63f23e79fc5f1

Patch Set 1 #

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-04-28 15:39:29 UTC) #1
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-04-28 16:11:55 UTC) #2
scheglov
3 years, 7 months ago (2017-04-28 16:30:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f0e1add54240cb65084935f010d63f23e79fc5f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698