chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java - Issue 2849873002: [Android WebAPK] Don't navigate WebAPK as a result of WindowClient.focus()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java

Issue 2849873002: [Android WebAPK] Don't navigate WebAPK as a result of WindowClient.focus() (Closed)

Patch Set: Merge branch 'master' into twitter Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDelegateFactory.java » ('j') | chrome/android/webapk/shell_apk/shell_apk_version.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java b/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java

index 7ed97b8a9e5eb3baebdd1dbf42131033de00bdf5..b8b840b967d719ed591910d1cddc24ff7f144350 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java

@@ -59,8 +59,8 @@ public class ServiceTabLauncher {

String webApkPackageName =

WebApkValidator.queryWebApkPackage(ContextUtils.getApplicationContext(), url);

if (webApkPackageName != null) {

- Intent intent =

- WebApkNavigationClient.createLaunchWebApkIntent(webApkPackageName, url);

+ Intent intent = WebApkNavigationClient.createLaunchWebApkIntent(

Yaron 2017/05/08 16:51:47 Hmm. i'm not thrilled with the idea that we have t

+ webApkPackageName, url, true /* forceNavigation */);

if (intent != null) {

intent.putExtra(ShortcutHelper.EXTRA_SOURCE, ShortcutSource.NOTIFICATION);

ContextUtils.getApplicationContext().startActivity(intent);