Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: net/quic/chromium/quic_chromium_client_session.cc

Issue 2849823005: Inline two methods of QuicChromiumClientSession (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.cc
diff --git a/net/quic/chromium/quic_chromium_client_session.cc b/net/quic/chromium/quic_chromium_client_session.cc
index bdf9326be9dcb0f41aa93f682a509a59e8ee0add..f7555d843d44c9c56e8aadf76d815448907e7967 100644
--- a/net/quic/chromium/quic_chromium_client_session.cc
+++ b/net/quic/chromium/quic_chromium_client_session.cc
@@ -1216,22 +1216,11 @@ void QuicChromiumClientSession::StartReading() {
}
}
-void QuicChromiumClientSession::CloseSessionOnError(int error,
+void QuicChromiumClientSession::CloseSessionOnError(int net_error,
QuicErrorCode quic_error) {
- RecordAndCloseSessionOnError(error, quic_error);
- NotifyFactoryOfSessionClosed();
-}
-
-void QuicChromiumClientSession::RecordAndCloseSessionOnError(
- int error,
- QuicErrorCode quic_error) {
- UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.CloseSessionOnError", -error);
- CloseSessionOnErrorInner(error, quic_error);
-}
+ UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.CloseSessionOnError",
+ -net_error);
-void QuicChromiumClientSession::CloseSessionOnErrorInner(
- int net_error,
- QuicErrorCode quic_error) {
if (!callback_.is_null()) {
base::ResetAndReturn(&callback_).Run(net_error);
}
@@ -1244,6 +1233,8 @@ void QuicChromiumClientSession::CloseSessionOnErrorInner(
connection()->CloseConnection(quic_error, "net error",
ConnectionCloseBehavior::SILENT_CLOSE);
DCHECK(!connection()->connected());
+
+ NotifyFactoryOfSessionClosed();
}
void QuicChromiumClientSession::CloseAllStreams(int net_error) {
« no previous file with comments | « net/quic/chromium/quic_chromium_client_session.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698