Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Unified Diff: net/quic/chromium/quic_chromium_client_session.h

Issue 2849823005: Inline two methods of QuicChromiumClientSession (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_chromium_client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_chromium_client_session.h
diff --git a/net/quic/chromium/quic_chromium_client_session.h b/net/quic/chromium/quic_chromium_client_session.h
index 262265340a524f2561affab7bd7d8e56eab6fc49..c8b68bcf2351d422699b352986456391ce6d90a2 100644
--- a/net/quic/chromium/quic_chromium_client_session.h
+++ b/net/quic/chromium/quic_chromium_client_session.h
@@ -224,7 +224,7 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
// Close the session because of |error| and notifies the factory
Zhongyi Shi 2017/04/29 21:05:19 nit: |net_error|
Ryan Hamilton 2017/05/01 02:02:05 Done.
// that this session has been closed, which will delete the session.
- void CloseSessionOnError(int error, QuicErrorCode quic_error);
+ void CloseSessionOnError(int net_error, QuicErrorCode quic_error);
std::unique_ptr<base::Value> GetInfoAsValue(
const std::set<HostPortPair>& aliases);
@@ -337,18 +337,6 @@ class NET_EXPORT_PRIVATE QuicChromiumClientSession
void OnClosedStream();
- // Close the session because of |error| and records it in UMA histogram.
- void RecordAndCloseSessionOnError(int error, QuicErrorCode quic_error);
-
- // A Session may be closed via any of three methods:
- // OnConnectionClosed - called by the connection when the connection has been
- // closed, perhaps due to a timeout or a protocol error.
- // CloseSessionOnError - called from the owner of the session,
- // the QuicStreamFactory, when there is an error.
- // OnReadComplete - when there is a read error.
- // This method closes all stream and performs any necessary cleanup.
- void CloseSessionOnErrorInner(int net_error, QuicErrorCode quic_error);
-
void CloseAllStreams(int net_error);
void CloseAllObservers(int net_error);
void CancelAllRequests(int net_error);
« no previous file with comments | « no previous file | net/quic/chromium/quic_chromium_client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698