Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.cc

Issue 2849823003: ChromeOS: implement per-user time zone preferences. (Closed)
Patch Set: Rebased. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/BUILD.gn ('k') | chrome/browser/chromeos/extensions/info_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/info_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/info_private_api.cc b/chrome/browser/chromeos/extensions/info_private_api.cc
index 29bd74e2387dafa036aa085ba42a4ce3aa4386e8..c69c4ab2b89759d47420881d17a6d9feeb25545a 100644
--- a/chrome/browser/chromeos/extensions/info_private_api.cc
+++ b/chrome/browser/chromeos/extensions/info_private_api.cc
@@ -326,6 +326,13 @@ std::unique_ptr<base::Value> ChromeosInfoPrivateGetFunction::GetValue(
}
if (property_name == kPropertyTimezone) {
+ if (chromeos::system::PerUserTimezoneEnabled()) {
+ return base::WrapUnique<base::Value>(
+ Profile::FromBrowserContext(context_)
+ ->GetPrefs()
+ ->GetUserPrefValue(prefs::kUserTimezone)
+ ->DeepCopy());
+ }
// TODO(crbug.com/697817): Convert CrosSettings::Get to take a unique_ptr.
return base::WrapUnique<base::Value>(
chromeos::CrosSettings::Get()
@@ -363,8 +370,13 @@ ExtensionFunction::ResponseAction ChromeosInfoPrivateSetFunction::Run() {
if (param_name == kPropertyTimezone) {
std::string param_value;
EXTENSION_FUNCTION_VALIDATE(args_->GetString(1, &param_value));
- chromeos::CrosSettings::Get()->Set(chromeos::kSystemTimezone,
- base::Value(param_value));
+ if (chromeos::system::PerUserTimezoneEnabled()) {
+ Profile::FromBrowserContext(context_)->GetPrefs()->SetString(
+ prefs::kUserTimezone, param_value);
+ } else {
+ chromeos::CrosSettings::Get()->Set(chromeos::kSystemTimezone,
+ base::Value(param_value));
+ }
} else {
const char* pref_name = GetBoolPrefNameForApiProperty(param_name.c_str());
if (pref_name) {
« no previous file with comments | « chrome/browser/chromeos/BUILD.gn ('k') | chrome/browser/chromeos/extensions/info_private_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698