ChromeOS: implement per-user time zone preferences.

chrome/browser/ui/webui/chromeos/set_time_ui.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/set_time_ui.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/build_time.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/system/timezone_util.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/browser_resources.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/system_clock_client.h"
 #include "chromeos/login/login_state.h"
 #include "chromeos/settings/timezone_settings.h"
+#include "components/prefs/pref_service.h"
+#include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 namespace chromeos {
 
 namespace {
 
+void SetUserTimezone(content::BrowserContext* browser_context,
+                     const std::string& timezone_id) {
+  Profile* profile = Profile::FromBrowserContext(browser_context);
+  DCHECK(profile);
+  Profile* primary_profile = ProfileManager::GetPrimaryUserProfile();
+  if (primary_profile && profile->IsSameProfile(primary_profile)) {
+    profile->GetPrefs()->SetString(prefs::kUserTimezone, timezone_id);
+  }
+}
+
 class SetTimeMessageHandler : public content::WebUIMessageHandler,
                               public chromeos::SystemClockClient::Observer,
                               public system::TimezoneSettings::Observer {
  public:
   SetTimeMessageHandler() {
     system::TimezoneSettings::GetInstance()->AddObserver(this);
     chromeos::DBusThreadManager::Get()->GetSystemClockClient()->AddObserver(
         this);
   }
 
@@ skipping 13 matching lines @@
         base::Bind(&SetTimeMessageHandler::OnSetTimezone,
                    base::Unretained(this)));
   }
 
  private:
   // system::SystemClockClient::Observer:
   void SystemClockUpdated() override {
     web_ui()->CallJavascriptFunctionUnsafe("settime.TimeSetter.updateTime");
   }
 
+  // UI actually shows real device timezone, but only allows changing the user
+  // timezone. If user timezone settings are different from system, this means
+  // that user settings are overriden and must be disabled. (And we will still
+  // show the actual device timezone.)
   // system::TimezoneSettings::Observer:
   void TimezoneChanged(const icu::TimeZone& timezone) override {
     base::Value timezone_id(system::TimezoneSettings::GetTimezoneID(timezone));
     web_ui()->CallJavascriptFunctionUnsafe("settime.TimeSetter.setTimezone",
                                            timezone_id);
   }
 
   // Handler for Javascript call to set the system clock when the user sets a
   // new time. Expects the time as the number of seconds since the Unix
   // epoch, treated as a double.
@@ skipping 11 matching lines @@
   // Handler for Javascript call to change the system time zone when the user
   // selects a new time zone. Expects the time zone ID as a string, as it
   // appears in the time zone option values.
   void OnSetTimezone(const base::ListValue* args) {
     std::string timezone_id;
     if (!args->GetString(0, &timezone_id)) {
       NOTREACHED();
       return;
     }
 
-    CrosSettings::Get()->SetString(kSystemTimezone, timezone_id);
+    if (system::PerUserTimezoneEnabled()) {
+      SetUserTimezone(web_ui()->GetWebContents()->GetBrowserContext(),

[michaelpg, 2017/05/30 22:21:23]

Please test this UI on the sign-in screen as well as Settings. What profile is
used on the sign-in screen in SetUserTimezone?

[Alexander Alekseev, 2017/07/06 06:30:29]

SigninProfile.

I updated this code (in timezone_util now) so that it will work for the signin
screen.

+                      timezone_id);
+    } else {
+      CrosSettings::Get()->SetString(kSystemTimezone, timezone_id);
+    }
   }
 
   DISALLOW_COPY_AND_ASSIGN(SetTimeMessageHandler);
 };
 
 }  // namespace
 
 SetTimeUI::SetTimeUI(content::WebUI* web_ui) : WebDialogUI(web_ui) {
   web_ui->AddMessageHandler(base::MakeUnique<SetTimeMessageHandler>());
 
@@ skipping 27 matching lines @@
   source->AddResourcePath("set_time.js", IDR_SET_TIME_JS);
   source->SetDefaultResource(IDR_SET_TIME_HTML);
 
   content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), source);
 }
 
 SetTimeUI::~SetTimeUI() {
 }
 
 }  // namespace chromeos