chromeos/settings/cros_settings_names.cc - Issue 2849823003: ChromeOS: implement per-user time zone preferences.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/settings/cros_settings_names.cc

Issue 2849823003: ChromeOS: implement per-user time zone preferences. (Closed)

Patch Set: Moved more code to previous CL. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/chromeos/set_time_ui.cc ('K') | « chromeos/settings/cros_settings_names.h ('k') | tools/metrics/histograms/enums.xml » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chromeos/settings/cros_settings_names.h"	5 #include "chromeos/settings/cros_settings_names.h"

6	6

7 namespace chromeos {	7 namespace chromeos {

8	8

9 const char kCrosSettingsPrefix[] = "cros.";	9 const char kCrosSettingsPrefix[] = "cros.";

10	10

(...skipping 227 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
238	238

239 // A list pref specifying the locales allowed on the login screen. Currently	239 // A list pref specifying the locales allowed on the login screen. Currently

240 // only the first value is used, as the single locale allowed on the login	240 // only the first value is used, as the single locale allowed on the login

241 // screen.	241 // screen.

242 const char kDeviceLoginScreenLocales[] = "cros.device_login_screen_locales";	242 const char kDeviceLoginScreenLocales[] = "cros.device_login_screen_locales";

243	243

244 // A list pref containing the input method IDs allowed on the login screen.	244 // A list pref containing the input method IDs allowed on the login screen.

245 const char kDeviceLoginScreenInputMethods[] =	245 const char kDeviceLoginScreenInputMethods[] =

246 "cros.device_login_screen_input_methods";	246 "cros.device_login_screen_input_methods";

247	247

	248 // A boolean pref that matches enable-per-user-time-zone chrome://flags value.

	249 const char kPerUserTimezoneEnabled[] = "cros.flags.per_user_timezone_enabled";
	stevenjb 2017/05/25 22:13:06 Why are we mapping a flag to a pref? In particular Why are we mapping a flag to a pref? In particular I find the HTML/JS code that uses prefs.cros.flags.per_user_timezone_enabled.value more complicated than it probably needs to be. Unless this can change dynamically, we should just set the value in loadTimeData like we do for other flags, e.g.: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/chromeo... Alexander Alekseev 2017/05/29 21:10:23 Done. Show quoted text On 2017/05/25 22:13:06, stevenjb wrote: > Why are we mapping a flag to a pref? In particular I find the HTML/JS code that > uses prefs.cros.flags.per_user_timezone_enabled.value more complicated than it > probably needs to be. Unless this can change dynamically, we should just set the > value in loadTimeData like we do for other flags, e.g.: > https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/chromeo... Done.
248 } // namespace chromeos	250 } // namespace chromeos

OLD	NEW