ChromeOS: implement per-user time zone preferences.

chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
 
 #include "base/guid.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 1364 matching lines @@
   // Expect the prefs to be cleared when cookies are removed.
   EXPECT_TRUE(prefs->GetString(omnibox::kZeroSuggestCachedResults).empty());
   EXPECT_EQ(content::BrowsingDataRemover::DATA_TYPE_COOKIES, GetRemovalMask());
   EXPECT_EQ(content::BrowsingDataRemover::ORIGIN_TYPE_UNPROTECTED_WEB,
             GetOriginTypeMask());
 }
 
 #if defined(OS_CHROMEOS)
 TEST_F(ChromeBrowsingDataRemoverDelegateTest,
        ContentProtectionPlatformKeysRemoval) {
-  chromeos::ScopedTestDeviceSettingsService test_device_settings_service;
-  chromeos::ScopedTestCrosSettings test_cros_settings;

[stevenjb, 2017/05/24 20:08:52]

Are these changes related? Can they be separated?

[Alexander Alekseev, 2017/05/25 00:30:05]

ChromeOS preferences are now tied to CrosSettings (to make user timezone 
default to current timezone to make transition correct), and to
components/user_manager .

This means that TestingProfile now needs CrosSettings and UserManager (for
GetProfileByUser() ) to run.

So it was reasonable to initialize them all in TestingProfile. Than we need to
remove duplicate initialization from the tests that had it previously.

It also turned out, that TestingProfile is used also in browser_tests and
interactive_ui_tests. So it now initializes only objects that has not been
already initialized.

UserManager did not support running in unit_tests (this is now fixed in this
CL).


Then, there was an incorrect object initialization sequence in one test, and a
bug in chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc .


We can move tests update to a separate CL, but it won't be obvious why it is
done.

   chromeos::MockUserManager* mock_user_manager =
       new testing::NiceMock<chromeos::MockUserManager>();
   mock_user_manager->SetActiveUser(
       AccountId::FromUserEmail("test@example.com"));
   chromeos::ScopedUserManagerEnabler user_manager_enabler(mock_user_manager);
 
   std::unique_ptr<chromeos::DBusThreadManagerSetter> dbus_setter =
       chromeos::DBusThreadManager::GetSetterForTesting();
   chromeos::MockCryptohomeClient* cryptohome_client =
       new chromeos::MockCryptohomeClient;
@@ skipping 938 matching lines @@
   base::Callback<bool(const GURL&)> origin_filter;
   tester.GetMockInfo(&remove_count, &data_type_mask, &origin_filter);
 
   EXPECT_EQ(1, remove_count);
   EXPECT_EQ(net::ReportingBrowsingDataRemover::DATA_TYPE_REPORTS |
                 net::ReportingBrowsingDataRemover::DATA_TYPE_CLIENTS,
             data_type_mask);
   EXPECT_TRUE(
       ProbablySameFilters(builder->BuildGeneralFilter(), origin_filter));
 }