Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2849803002: Revert "Add typedef AST node boilerplate." (Closed)

Created:
3 years, 7 months ago by asgerf
Modified:
3 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add typedef AST node boilerplate." This reverts commit d1c3ee4b35227cb6926f03479a34f82774523773. TBR BUG= Committed: https://github.com/dart-lang/sdk/commit/3f1aa32183ec3ef8a7dd5df6c2eabe29cb180566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -707 lines) Patch
M pkg/kernel/lib/ast.dart View 9 chunks +0 lines, -145 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 4 chunks +0 lines, -31 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 3 chunks +0 lines, -16 lines 0 comments Download
M pkg/kernel/lib/binary/tag.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/kernel/lib/canonical_name.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 6 chunks +0 lines, -31 lines 0 comments Download
M pkg/kernel/lib/transformations/reify/transformation/remove_generics.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/kernel/lib/transformations/treeshaker.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/kernel/lib/type_algebra.dart View 3 chunks +0 lines, -20 lines 0 comments Download
M pkg/kernel/lib/type_environment.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/kernel/lib/verifier.dart View 9 chunks +6 lines, -65 lines 0 comments Download
M pkg/kernel/lib/visitor.dart View 3 chunks +0 lines, -4 lines 0 comments Download
M pkg/kernel/test/type_parser.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D pkg/kernel/test/typedef_unalias_test.dart View 1 chunk +0 lines, -68 lines 0 comments Download
M pkg/kernel/test/verify_test.dart View 1 chunk +0 lines, -165 lines 0 comments Download
M runtime/vm/kernel.h View 9 chunks +1 line, -72 lines 0 comments Download
M runtime/vm/kernel.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M runtime/vm/kernel_binary.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/kernel_binary.cc View 5 chunks +0 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
There was an issue with FastaVerifyingVisitor which I had not updated. [error] Invalid override. The ...
3 years, 7 months ago (2017-04-28 10:53:15 UTC) #2
asgerf
Committed patchset #1 (id:1) manually as 3f1aa32183ec3ef8a7dd5df6c2eabe29cb180566 (presubmit successful).
3 years, 7 months ago (2017-04-28 10:54:25 UTC) #5
ahe
3 years, 7 months ago (2017-04-28 10:57:01 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698