Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: tools/release/test_update_node.py

Issue 2849783003: Update update_node to new gtest path.
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/release/testdata/v8/.gitignore » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/release/test_update_node.py
diff --git a/tools/release/test_update_node.py b/tools/release/test_update_node.py
index bff3d08c2f0612af368da34d25422c5446e3118f..ed41c4f408935b073b4fcf84a361591d92c8cff9 100755
--- a/tools/release/test_update_node.py
+++ b/tools/release/test_update_node.py
@@ -18,12 +18,16 @@ TEST_DATA = os.path.join(BASE_DIR, 'testdata')
# Expectations.
EXPECTED_GITIGNORE = """
-/testing/gtest/*
-!/testing/gtest/include
-/testing/gtest/include/*
-!/testing/gtest/include/gtest
-/testing/gtest/include/gtest/*
-!/testing/gtest/include/gtest/gtest_prod.h
+/third_party/googletest/*
+!/third_party/googletest/src
+/third_party/googletest/src/*
+!/third_party/googletest/src/googletest
+/third_party/googletest/src/googletest/*
+!/third_party/googletest/src/googletest/include
+/third_party/googletest/src/googletest/include/*
+!/third_party/googletest/src/googletest/include/gtest
+/third_party/googletest/src/googletest/include/gtest/*
+!/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
!/third_party/jinja2
!/third_party/markupsafe
/unrelated
@@ -32,7 +36,9 @@ EXPECTED_GITIGNORE = """
EXPECTED_GIT_DIFF = """
create mode 100644 deps/v8/base/trace_event/common/common
rename deps/v8/baz/{delete_me => v8_new} (100%)
+ delete mode 100644 deps/v8/include/v8-version.h
rename deps/v8/{delete_me => new/v8_new} (100%)
+ create mode 100644 deps/v8/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
create mode 100644 deps/v8/third_party/jinja2/jinja2
create mode 100644 deps/v8/third_party/markupsafe/markupsafe
create mode 100644 deps/v8/v8_new
@@ -42,9 +48,9 @@ ADDED_FILES = [
'v8_new',
'new/v8_new',
'baz/v8_new',
- 'testing/gtest/gtest_new',
- 'testing/gtest/new/gtest_new',
- 'testing/gtest/baz/gtest_new',
+ '/third_party/googletest/src/googletest/include/gtest/gtest_new',
+ '/third_party/googletest/src/googletest/include/gtest/new/gtest_new',
+ '/third_party/googletest/src/googletest/include/gtest/baz/gtest_new',
'third_party/jinja2/jinja2',
'third_party/markupsafe/markupsafe'
]
@@ -106,6 +112,8 @@ class TestUpdateNode(unittest.TestCase):
['git', 'diff', 'master', '--summary'],
cwd=node_cwd,
)
+ print
+ print EXPECTED_GIT_DIFF
self.assertEquals(EXPECTED_GIT_DIFF.strip(), gitlog.strip())
# Check patch.
« no previous file with comments | « no previous file | tools/release/testdata/v8/.gitignore » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698