Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2849773002: Revert of Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes.

Created:
3 years, 7 months ago by Dan Ehrenberg
Modified:
3 years, 7 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes. (patchset #5 id:80001 of https://codereview.chromium.org/2176653003/ ) Reason for revert: Blamed for https://bugs.chromium.org/p/chromium/issues/detail?id=716265 Original issue's description: > Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes. > > This slightly simplifies scope handling. It also makes it possible to > implement some potential future changes to classes purely in the parser > by adding additional code to the DoExpression. > > This is a portion of https://codereview.chromium.org/2142333002/, which > probably isn't going through in full. > > Committed: https://crrev.com/c2bcfc31454bfa95e146cb6002fb6a9a142181f7 > Cr-Commit-Position: refs/heads/master@{#38035} TBR=adamk@chromium.org,marja@chromium.org,mstarzinger@chromium.org,bakkot@google.com # Not skipping CQ checks because original CL landed more than 1 days ago.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -201 lines) Patch
M src/ast/ast.h View 7 chunks +21 lines, -20 lines 0 comments Download
M src/ast/ast.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +39 lines, -32 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/parsing/parameter-initializer-rewriter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser.h View 2 chunks +10 lines, -10 lines 0 comments Download
M src/parsing/parser.cc View 5 chunks +12 lines, -25 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 5 chunks +102 lines, -106 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
Dan Ehrenberg
Created Revert of Wrap ClassLiterals in DoExpressions instead of giving them BlockScopes.
3 years, 7 months ago (2017-04-28 08:33:22 UTC) #1
adamk
3 years, 7 months ago (2017-04-28 16:52:27 UTC) #6
This landed a looooong time ago. Not sure a straight revert is a good idea (nor
am I certain that this is better than fixing the underlying issue). Am following
the bug.

Powered by Google App Engine
This is Rietveld 408576698