Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: components/autofill/core/browser/autofill_manager.h

Issue 2849753002: Logs all reasons card upload was not offered in UKM and UMA. (Closed)
Patch Set: Formatting fix. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.h
diff --git a/components/autofill/core/browser/autofill_manager.h b/components/autofill/core/browser/autofill_manager.h
index 83915b57441687a54bf9be6268efc5af1f076f3c..6571f533c4106636d59af24e76da2a239d3e7552 100644
--- a/components/autofill/core/browser/autofill_manager.h
+++ b/components/autofill/core/browser/autofill_manager.h
@@ -427,20 +427,18 @@ class AutofillManager : public AutofillDownloadManager::Observer,
void ImportFormData(const FormStructure& submitted_form);
// Logs |metric_name| with RAPPOR, for the specific form |source_url|.
- void CollectRapportSample(const GURL& source_url,
- const std::string& metric_name) const;
+ void CollectRapporSample(const GURL& source_url,
+ const std::string& metric_name) const;
// Examines |card| and the stored profiles and if a candidate set of profiles
// is found that matches the client-side validation rules, assigns the values
- // to |profiles|. If no valid set can be found, returns false, assigns the
- // failure reason to |address_upload_decision_metric|, and if applicable, the
- // RAPPOR metric to log to |rappor_metric_name|.
- bool GetProfilesForCreditCardUpload(const CreditCard& card,
- std::vector<AutofillProfile>* profiles,
- autofill::AutofillMetrics::
- CardUploadDecisionMetric*
- address_upload_decision_metric,
- std::string* rappor_metric_name) const;
+ // to |profiles| and returns 0. If no valid set can be found, returns the
+ // failure reasons and, if applicable, the RAPPOR metric to log to
+ // |rappor_metric_name|. The return value is a bitmask of
+ // |AutofillMetrics::CardUploadDecisionMetric|.
+ int GetProfilesForCreditCardUpload(const CreditCard& card,
+ std::vector<AutofillProfile>* profiles,
+ std::string* rappor_metric_name) const;
// If |initial_interaction_timestamp_| is unset or is set to a later time than
// |interaction_timestamp|, updates the cached timestamp. The latter check is
@@ -486,9 +484,10 @@ class AutofillManager : public AutofillDownloadManager::Observer,
void DumpAutofillData(bool imported_cc) const;
#endif
- // Logs the card upload decision UKM.
- void LogCardUploadDecisionUkm(
- AutofillMetrics::CardUploadDecisionMetric upload_decision);
+ // Logs the card upload decisions in UKM and UMA.
+ // |upload_decision_metrics| is a bitmask of
+ // |AutofillMetrics::CardUploadDecisionMetric|.
+ void LogCardUploadDecisions(int upload_decision_metrics);
// Provides driver-level context to the shared code of the component. Must
// outlive this object.

Powered by Google App Engine
This is Rietveld 408576698