Logs all reasons card upload was not offered in UKM and UMA.

components/autofill/core/browser/autofill_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 61 matching lines @@
   GROUP_CREDIT_CARD_NUMBER,
   GROUP_CREDIT_CARD_DATE,
   GROUP_CREDIT_CARD_TYPE,
   GROUP_PASSWORD,
   GROUP_ADDRESS_LINE_3,
   GROUP_USERNAME,
   GROUP_STREET_ADDRESS,
   GROUP_CREDIT_CARD_VERIFICATION,
   NUM_FIELD_TYPE_GROUPS_FOR_METRICS
 };
 

[Jared Saul, 2017/05/01 21:05:12]

I have no idea what this is; can you please add a comment above it explaining
it?

[csashi, 2017/05/02 00:43:56]

Seemed self-explanatory:
https://cs.chromium.org/chromium/src/components/autofill/core/common/autofill...

[Jared Saul, 2017/05/02 01:39:45]

I think "previous" is what's throwing me off here, because I'm finding it hard
to make a clear assumption on what the timeframe of "previous" is.  Does Chrome
actually remember what you picked last time it offered to save, even if it was
like a year ago?  I thought Chrome didn't have anything like that.

[csashi, 2017/05/02 20:23:31]

That is a good question, but is orthogonal to the documentation for this
function though.  All this function is doing is converting that enum to a
string.

I am using the same preferences that we use to remember if someone accepted a
checkbox. Whatever timeframe applies to that choice, should apply to this as
well.

 std::string PreviousSaveCreditCardPromptUserDecisionToString(
     int previous_save_credit_card_prompt_user_decision) {
   DCHECK_LT(previous_save_credit_card_prompt_user_decision,
             prefs::NUM_PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISIONS);
   std::string previous_response;
   if (previous_save_credit_card_prompt_user_decision ==
       prefs::PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISION_ACCEPTED)
     previous_response = ".PreviouslyAccepted";
   else if (previous_save_credit_card_prompt_user_decision ==
            prefs::PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISION_DENIED)
@@ skipping 210 matching lines @@
                              field_type_group_metric,
                              num_field_type_group_metrics);
 }
 
 }  // namespace
 
 // static
 void AutofillMetrics::LogCardUploadDecisionMetric(
     CardUploadDecisionMetric metric) {
   DCHECK_LT(metric, NUM_CARD_UPLOAD_DECISION_METRICS);
-  UMA_HISTOGRAM_ENUMERATION("Autofill.CardUploadDecisionExpanded", metric,
+  UMA_HISTOGRAM_ENUMERATION("Autofill.CardUploadDecisionMetric", metric,
                             NUM_CARD_UPLOAD_DECISION_METRICS);
 }
 
 // static
 void AutofillMetrics::LogCreditCardInfoBarMetric(
     InfoBarMetric metric,
     bool is_uploading,
     int previous_save_credit_card_prompt_user_decision) {
   DCHECK_LT(metric, NUM_INFO_BAR_METRICS);
 
@@ skipping 418 matching lines @@
                             NUM_CONVERTED_ADDRESS_CONVERSION_TYPES);
 }
 
 // static
 void AutofillMetrics::LogShowedHttpNotSecureExplanation() {
   base::RecordAction(
       base::UserMetricsAction("Autofill_ShowedHttpNotSecureExplanation"));
 }
 
 // static
-void AutofillMetrics::LogCardUploadDecisionUkm(
-    ukm::UkmService* ukm_service,
-    const GURL& url,
-    AutofillMetrics::CardUploadDecisionMetric upload_decision) {
-  if (upload_decision >= AutofillMetrics::NUM_CARD_UPLOAD_DECISION_METRICS)
-    return;
+void AutofillMetrics::LogCardUploadDecisionsUkm(ukm::UkmService* ukm_service,
+                                                const GURL& url,
+                                                int upload_decision_metrics) {
+  DCHECK(upload_decision_metrics);
+  DCHECK_LT(upload_decision_metrics, 1 << NUM_CARD_UPLOAD_DECISION_METRICS);
 
   const std::vector<std::pair<const char*, int>> metrics = {
-      {internal::kUKMCardUploadDecisionMetricName,
-       static_cast<int>(upload_decision)}};
+      {internal::kUKMCardUploadDecisionMetricName, upload_decision_metrics}};
   LogUkm(ukm_service, url, internal::kUKMCardUploadDecisionEntryName, metrics);
 }
 
 // static
 void AutofillMetrics::LogDeveloperEngagementUkm(
     ukm::UkmService* ukm_service,
     const GURL& url,
-    std::vector<AutofillMetrics::DeveloperEngagementMetric> metrics) {
-  std::vector<std::pair<const char*, int>> form_structure_metrics;
-  for (const auto it : metrics)
-    form_structure_metrics.push_back(
-        {internal::kUKMDeveloperEngagementMetricName, static_cast<int>(it)});
+    int developer_engagement_metrics) {
+  DCHECK(developer_engagement_metrics);
+  DCHECK_LT(developer_engagement_metrics,
+            1 << NUM_DEVELOPER_ENGAGEMENT_METRICS);
 
-  LogUkm(ukm_service, url, internal::kUKMDeveloperEngagementEntryName,
-         form_structure_metrics);
+  const std::vector<std::pair<const char*, int>> metrics = {
+      {internal::kUKMDeveloperEngagementMetricName,
+       developer_engagement_metrics}};
+
+  LogUkm(ukm_service, url, internal::kUKMDeveloperEngagementEntryName, metrics);
 }
 
 // static
 bool AutofillMetrics::LogUkm(
     ukm::UkmService* ukm_service,
     const GURL& url,
     const std::string& ukm_entry_name,
     const std::vector<std::pair<const char*, int>>& metrics) {
   if (!IsUkmLoggingEnabled() || !ukm_service || !url.is_valid() ||
       metrics.empty()) {
@@ skipping 364 matching lines @@
   DCHECK(!form_loaded_timestamp_.is_null());
   return (base::TimeTicks::Now() - form_loaded_timestamp_).InMilliseconds();
 }
 
 void AutofillMetrics::FormInteractionsUkmLogger::GetNewSourceID() {
   source_id_ = ukm_service_->GetNewSourceID();
   ukm_service_->UpdateSourceURL(source_id_, url_);
 }
 
 }  // namespace autofill