Logs all reasons card upload was not offered in UKM and UMA.

components/autofill/core/browser/autofill_metrics.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 #include <utility>
@@ skipping 77 matching lines @@
   enum AutofillFormSubmittedState {
     NON_FILLABLE_FORM_OR_NEW_DATA,
     FILLABLE_FORM_AUTOFILLED_ALL,
     FILLABLE_FORM_AUTOFILLED_SOME,
     FILLABLE_FORM_AUTOFILLED_NONE_DID_SHOW_SUGGESTIONS,
     FILLABLE_FORM_AUTOFILLED_NONE_DID_NOT_SHOW_SUGGESTIONS,
     AUTOFILL_FORM_SUBMITTED_STATE_ENUM_SIZE,
   };
 
   enum CardUploadDecisionMetric {
-    // All the required conditions were satisfied and the card upload prompt was
-    // triggered.
-    UPLOAD_OFFERED,
+    // Card upload prompt was triggered either because all the conditions were
+    // automatically satisfied or because we can potentially fix fields to
+    // satisfy some conditions. For example, requesting user to input CVC when
+    // CVC was missing. See |UPLOAD_OFFERED_NO_CVC|.
+    UPLOAD_OFFERED = 1 << 0,
     // No CVC was detected. We don't know whether any addresses were available
     // nor whether we would have been able to get upload details.
-    UPLOAD_NOT_OFFERED_NO_CVC,
+    UPLOAD_NOT_OFFERED_NO_CVC = 1 << 1,
     // A CVC was detected but no recently created or used address was available.
     // We don't know whether we would have been able to get upload details.
-    UPLOAD_NOT_OFFERED_NO_ADDRESS,
+    UPLOAD_NOT_OFFERED_NO_ADDRESS = 1 << 2,
     // A CVC and one or more addresses were available but no name was found on
     // either the card or the adress(es). We don't know whether the address(es)
     // were otherwise valid nor whether we would have been able to get upload
     // details.
-    UPLOAD_NOT_OFFERED_NO_NAME,
+    UPLOAD_NOT_OFFERED_NO_NAME = 1 << 3,
     // A CVC, multiple addresses, and a name were available but the adresses had
     // conflicting zip codes. We don't know whether we would have been able to
     // get upload details.
-    UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS,
+    UPLOAD_NOT_OFFERED_CONFLICTING_ZIPS = 1 << 4,
     // A CVC, one or more addresses, and a name were available but no zip code
     // was found on any of the adress(es). We don't know whether we would have
     // been able to get upload details.
-    UPLOAD_NOT_OFFERED_NO_ZIP_CODE,
+    UPLOAD_NOT_OFFERED_NO_ZIP_CODE = 1 << 5,
     // A CVC, one or more valid addresses, and a name were available but the
     // request to Payments for upload details failed.
-    UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED,
+    UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED = 1 << 6,
     // A CVC and one or more addresses were available but the names on the card
     // and/or the addresses didn't match. We don't know whether the address(es)
     // were otherwise valid nor whether we would have been able to get upload
     // details.
-    UPLOAD_NOT_OFFERED_CONFLICTING_NAMES,
+    UPLOAD_NOT_OFFERED_CONFLICTING_NAMES = 1 << 7,
     // No CVC was detected, but valid addresses and names were.  Upload is still
     // possible if the user manually enters CVC, so upload was offered.
-    UPLOAD_OFFERED_NO_CVC,
-    NUM_CARD_UPLOAD_DECISION_METRICS,
+    UPLOAD_OFFERED_NO_CVC = 1 << 8,
+    // One or more of the required conditions were not satisfied and the card
+    // upload prompt was not triggered.
+    UPLOAD_NOT_OFFERED = 1 << 9,

[Steven Holte, 2017/05/02 19:33:20]

Does it make sense to simplify some of these bits?  e.g. will you always have
set one of UPLOAD_OFFERED | UPLOAD_NOT_OFFERED?  It seems like you always record
record some together as well, e.g. UPLOAD_NOT_OFFERED &
UPLOAD_NOT_OFFERED_GET_UPLOAD_DETAILS_FAILED, so the second bit isn't exactly
adding the UPLOAD_NOT_OFFERED information itself.

Maybe you could simplify this down to a list of conditions, e.g:

OFFER_DECIDED, (Not sure if you need?)
OFFERED,
NO_CVC,
NO_ADDRESS,
NO_NAME,
CONFLICTING_NAMES,
NO_ZIP,
CONFLICTING_ZIP,
GET_UPLOAD_DETAILS_FAILED

[csashi, 2017/05/02 20:23:31]

Done. There are no redundant bits now.

Our intent to redundantly log OFFERED and NOT_OFFERED was to make it easy to
quickly calculate success & failure rates. But we can move that to the analysis
tools / calculations.

+    // Update |kNumCardUploadDecisionMetrics| when adding new enum here.
   };
 
   enum DeveloperEngagementMetric {
     // Parsed a form that is potentially autofillable and does not contain any
     // web developer-specified field type hint.
     FILLABLE_FORM_PARSED_WITHOUT_TYPE_HINTS = 0,
     // Parsed a form that is potentially autofillable and contains at least one
     // web developer-specified field type hint, a la
     // http://is.gd/whatwg_autocomplete
     FILLABLE_FORM_PARSED_WITH_TYPE_HINTS,
@@ skipping 496 matching lines @@
     bool CanLog() const;
     int64_t MillisecondsSinceFormLoaded() const;
     void GetNewSourceID();
 
     ukm::UkmService* ukm_service_;  // Weak reference.
     int32_t source_id_ = -1;
     GURL url_;
     base::TimeTicks form_loaded_timestamp_;
   };
 
-  static void LogCardUploadDecisionMetric(CardUploadDecisionMetric metric);
+  // |upload_decision_metrics| is a bitmask of |CardUploadDecisionMetric|.
+  static void LogCardUploadDecisionMetrics(int upload_decision_metrics);
   static void LogCreditCardInfoBarMetric(
       InfoBarMetric metric,
       bool is_uploading,
       int previous_save_credit_card_prompt_user_decision);
   static void LogCreditCardFillingInfoBarMetric(InfoBarMetric metric);
   static void LogSaveCardPromptMetric(
       SaveCardPromptMetric metric,
       bool is_uploading,
       bool is_reshow,
       int previous_save_credit_card_prompt_user_decision);
@@ skipping 138 matching lines @@
   static void LogIsQueriedCreditCardFormSecure(bool is_secure);
 
   // Log how the converted wallet address was added to the local autofill
   // profiles.
   static void LogWalletAddressConversionType(WalletAddressConversionType type);
 
   // This should be called when the user selects the Form-Not-Secure warning
   // suggestion to show an explanation of the warning.
   static void LogShowedHttpNotSecureExplanation();
 
-  // Logs the card upload decision ukm based on the specified |url| and
-  // |upload_decision|.
-  static void LogCardUploadDecisionUkm(
-      ukm::UkmService* ukm_service,
-      const GURL& url,
-      AutofillMetrics::CardUploadDecisionMetric upload_decision);
+  // Logs the card upload decisions ukm for the specified |url|.
+  // |upload_decision_metrics| is a bitmask of |CardUploadDecisionMetric|.
+  static void LogCardUploadDecisionsUkm(ukm::UkmService* ukm_service,
+                                        const GURL& url,
+                                        int upload_decision_metrics);
 
   // Logs the developer engagement ukm for the specified |url| and autofill
-  // fields in the form structure.
-  static void LogDeveloperEngagementUkm(
-      ukm::UkmService* ukm_service,
-      const GURL& url,
-      std::vector<AutofillMetrics::DeveloperEngagementMetric> metrics);
+  // fields in the form structure. |developer_engagement_metrics| is a bitmask
+  // of |AutofillMetrics::DeveloperEngagementMetric|.
+  static void LogDeveloperEngagementUkm(ukm::UkmService* ukm_service,
+                                        const GURL& url,
+                                        int developer_engagement_metrics);
 
   // Logs the the |ukm_entry_name| with the specified |url| and the specified
   // |metrics|. Returns whether the ukm was sucessfully logged.
   static bool LogUkm(ukm::UkmService* ukm_service,
                      const GURL& url,
                      const std::string& ukm_entry_name,
                      const std::vector<std::pair<const char*, int>>& metrics);
 
   // Utility to log autofill form events in the relevant histograms depending on
   // the presence of server and/or local data.
@@ skipping 49 matching lines @@
     bool logged_suggestion_filled_was_masked_server_card_;
 
     // The last field that was polled for suggestions.
     FormFieldData last_polled_field_;
 
     FormInteractionsUkmLogger*
         form_interactions_ukm_logger_;  // Weak reference.
   };
 
  private:
+  static const int kNumCardUploadDecisionMetrics = 10;
+
   DISALLOW_IMPLICIT_CONSTRUCTORS(AutofillMetrics);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_METRICS_H_