chrome/browser/ui/page_info/page_info.cc - Issue 2849713003: Move all Page Info strings into page_info_strings.grdp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/page_info/page_info.cc

Issue 2849713003: Move all Page Info strings into page_info_strings.grdp (Closed)

Patch Set: IDS_PAGE_INFO_NON_SECURE_TRANSPORT -> IDS_PAGEINFO_NOT_SECURE_SUMMARY Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/page_info/page_info.cc

diff --git a/chrome/browser/ui/page_info/page_info.cc b/chrome/browser/ui/page_info/page_info.cc

index 26b3aa4c91f8ddb5a4189da60f35912eec0e8394..7f5a02546b95455137f6a0cf3779f2f114e29e07 100644

--- a/chrome/browser/ui/page_info/page_info.cc

+++ b/chrome/browser/ui/page_info/page_info.cc

@@ -45,7 +45,6 @@

#include "chrome/browser/usb/usb_chooser_context_factory.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/url_constants.h"

-#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

estark 2017/04/28 05:05:25 is this still needed?

lgarron 2017/04/28 22:04:32 Nope, as long as we move IDS_CERT_POLICY_PROVIDED_

#include "chrome/grit/theme_resources.h"

#include "components/content_settings/core/browser/content_settings_utils.h"