Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart

Issue 2849703002: Fix following comma detection in code completion (#29503). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
index 1fd8852e03c1c15ebea728e9d14bdd0bd6d200b3..31f5725144229bdd739edbe19997745bd1e9bb0a 100644
--- a/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart
@@ -892,6 +892,31 @@ build() => new Row(
selectionOffset: 10);
}
+ test_ArgumentList_Flutter_InstanceCreationExpression_01() async {
+ configureFlutterPkg({
+ 'src/widgets/framework.dart': flutter_framework_code,
+ });
+
+ addTestSource('''
+import 'package:flutter/src/widgets/framework.dart';
+
+ build() => new Scaffold(
+ appBar: new AppBar(
+ ^
+ ),
+ );
+''');
+
+ // Don't generate children boilerplate.
+ await computeSuggestions();
+
+ assertSuggest('color: ,',
+ csKind: CompletionSuggestionKind.NAMED_ARGUMENT,
+ relevance: DART_RELEVANCE_NAMED_PARAMETER,
+ defaultArgListString: null, // No default values.
+ selectionOffset: 7);
+ }
+
test_ArgumentList_Flutter_InstanceCreationExpression_1() async {
configureFlutterPkg({
'src/widgets/framework.dart': flutter_framework_code,

Powered by Google App Engine
This is Rietveld 408576698