Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2849703002: Fix following comma detection in code completion (#29503). (Closed)

Created:
3 years, 7 months ago by pquitslund
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/flutter_util.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
3 years, 7 months ago (2017-04-27 22:53:52 UTC) #2
pquitslund
Video of fix: https://github.com/dart-lang/sdk/issues/29503
3 years, 7 months ago (2017-04-27 22:55:19 UTC) #3
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-04-27 23:07:33 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as daa399499dde710f1fde047b5fcb893d6198dede (presubmit successful).
3 years, 7 months ago (2017-04-27 23:52:39 UTC) #6
danrubel
3 years, 7 months ago (2017-04-28 02:04:02 UTC) #7
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698