ppapi/proxy/video_decoder_resource.cc - Issue 2849633002: Get rid of base::SharedMemory::NULLHandle();

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/video_decoder_resource.cc

Issue 2849633002: Get rid of base::SharedMemory::NULLHandle(); (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/proxy/video_decoder_resource.cc

diff --git a/ppapi/proxy/video_decoder_resource.cc b/ppapi/proxy/video_decoder_resource.cc

index cb55764bff4360e6a104243be87344acdbaaea78..26fee48177ec299412a7bed284dbfff87a5e0254 100644

--- a/ppapi/proxy/video_decoder_resource.cc

+++ b/ppapi/proxy/video_decoder_resource.cc

@@ -227,7 +227,7 @@ int32_t VideoDecoderResource::Decode(uint32_t decode_id,

if (!UnpackMessage<PpapiPluginMsg_VideoDecoder_GetShmReply>(reply,

&shm_size))

return PP_ERROR_FAILED;

- base::SharedMemoryHandle shm_handle = base::SharedMemory::NULLHandle();

+ base::SharedMemoryHandle shm_handle;

if (!reply_params.TakeSharedMemoryHandleAtIndex(0, &shm_handle))

return PP_ERROR_NOMEMORY;

std::unique_ptr<base::SharedMemory> shm(

« no previous file with comments | « ppapi/proxy/serialized_handle.cc ('k') | ui/gfx/gpu_memory_buffer.cc » ('j') | no next file with comments »