content/renderer/renderer_blink_platform_impl.cc - Issue 2849633002: Get rid of base::SharedMemory::NULLHandle();

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 2849633002: Get rid of base::SharedMemory::NULLHandle(); (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/renderer_blink_platform_impl.cc

diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc

index f299044aed658e30ffad74ddaa9bf72a30fa7723..371943b8479728f0ed260c7f5fb9d352511f2f40 100644

--- a/content/renderer/renderer_blink_platform_impl.cc

+++ b/content/renderer/renderer_blink_platform_impl.cc

@@ -546,8 +546,7 @@ bool RendererBlinkPlatformImpl::SandboxSupport::LoadFont(NSFont* src_font,

return false;

}

- if (font_data_size == 0 || font_data == base::SharedMemory::NULLHandle() ||

- *font_id == 0) {

+ if (font_data_size == 0 || !font_data.IsValid() || *font_id == 0) {

LOG(ERROR) << "Bad response from RenderProcessHostMsg_LoadFont() for " <<

src_font_descriptor.font_name;

*out = NULL;