Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: content/renderer/media/audio_message_filter_unittest.cc

Issue 2849633002: Get rid of base::SharedMemory::NULLHandle(); (Closed)
Patch Set: Rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 void OnIPCClosed() override {} 47 void OnIPCClosed() override {}
48 48
49 void Reset() { 49 void Reset() {
50 error_received_ = false; 50 error_received_ = false;
51 51
52 device_authorized_received_ = false; 52 device_authorized_received_ = false;
53 output_params_ = media::AudioParameters(); 53 output_params_ = media::AudioParameters();
54 device_status_ = media::OUTPUT_DEVICE_STATUS_ERROR_INTERNAL; 54 device_status_ = media::OUTPUT_DEVICE_STATUS_ERROR_INTERNAL;
55 55
56 created_received_ = false; 56 created_received_ = false;
57 handle_ = base::SharedMemory::NULLHandle(); 57 handle_ = base::SharedMemoryHandle();
58 length_ = 0; 58 length_ = 0;
59 59
60 volume_received_ = false; 60 volume_received_ = false;
61 volume_ = 0; 61 volume_ = 0;
62 } 62 }
63 63
64 bool error_received() { return error_received_; } 64 bool error_received() { return error_received_; }
65 65
66 bool device_authorized_received() { return device_authorized_received_; } 66 bool device_authorized_received() { return device_authorized_received_; }
67 media::AudioParameters output_params() { return output_params_; } 67 media::AudioParameters output_params() { return output_params_; }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 kEmptyMatchedDeviceId)); 123 kEmptyMatchedDeviceId));
124 EXPECT_TRUE(delegate.device_authorized_received()); 124 EXPECT_TRUE(delegate.device_authorized_received());
125 EXPECT_TRUE(delegate.output_params().Equals(MockOutputParams())); 125 EXPECT_TRUE(delegate.output_params().Equals(MockOutputParams()));
126 delegate.Reset(); 126 delegate.Reset();
127 127
128 // AudioMsg_NotifyStreamCreated 128 // AudioMsg_NotifyStreamCreated
129 base::SyncSocket::TransitDescriptor socket_descriptor; 129 base::SyncSocket::TransitDescriptor socket_descriptor;
130 const uint32_t kLength = 1024; 130 const uint32_t kLength = 1024;
131 EXPECT_FALSE(delegate.created_received()); 131 EXPECT_FALSE(delegate.created_received());
132 filter->OnMessageReceived(AudioMsg_NotifyStreamCreated( 132 filter->OnMessageReceived(AudioMsg_NotifyStreamCreated(
133 kStreamId, base::SharedMemory::NULLHandle(), socket_descriptor, kLength)); 133 kStreamId, base::SharedMemoryHandle(), socket_descriptor, kLength));
134 EXPECT_TRUE(delegate.created_received()); 134 EXPECT_TRUE(delegate.created_received());
135 EXPECT_FALSE(base::SharedMemory::IsHandleValid(delegate.handle())); 135 EXPECT_FALSE(base::SharedMemory::IsHandleValid(delegate.handle()));
136 EXPECT_EQ(kLength, delegate.length()); 136 EXPECT_EQ(kLength, delegate.length());
137 delegate.Reset(); 137 delegate.Reset();
138 138
139 // AudioMsg_NotifyStreamStateChanged 139 // AudioMsg_NotifyStreamStateChanged
140 EXPECT_FALSE(delegate.error_received()); 140 EXPECT_FALSE(delegate.error_received());
141 filter->OnMessageReceived(AudioMsg_NotifyStreamError(kStreamId)); 141 filter->OnMessageReceived(AudioMsg_NotifyStreamError(kStreamId));
142 EXPECT_TRUE(delegate.error_received()); 142 EXPECT_TRUE(delegate.error_received());
143 delegate.Reset(); 143 delegate.Reset();
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 185
186 ipc1->CloseStream(); 186 ipc1->CloseStream();
187 ipc2->CloseStream(); 187 ipc2->CloseStream();
188 EXPECT_EQ(static_cast<media::AudioOutputIPCDelegate*>(NULL), 188 EXPECT_EQ(static_cast<media::AudioOutputIPCDelegate*>(NULL),
189 filter->delegates_.Lookup(kStreamId1)); 189 filter->delegates_.Lookup(kStreamId1));
190 EXPECT_EQ(static_cast<media::AudioOutputIPCDelegate*>(NULL), 190 EXPECT_EQ(static_cast<media::AudioOutputIPCDelegate*>(NULL),
191 filter->delegates_.Lookup(kStreamId2)); 191 filter->delegates_.Lookup(kStreamId2));
192 } 192 }
193 193
194 } // namespace content 194 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698