Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: components/nacl/common/nacl_types.cc

Issue 2849633002: Get rid of base::SharedMemory::NULLHandle(); (Closed)
Patch Set: Rebase. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 #include "components/nacl/common/nacl_types.h" 6 #include "components/nacl/common/nacl_types.h"
7 #include "ipc/ipc_platform_file.h" 7 #include "ipc/ipc_platform_file.h"
8 8
9 namespace nacl { 9 namespace nacl {
10 10
11 NaClStartParams::NaClStartParams() 11 NaClStartParams::NaClStartParams()
12 : nexe_file(IPC::InvalidPlatformFileForTransit()), 12 : nexe_file(IPC::InvalidPlatformFileForTransit()),
13 irt_handle(IPC::InvalidPlatformFileForTransit()), 13 irt_handle(IPC::InvalidPlatformFileForTransit()),
14 #if defined(OS_POSIX) 14 #if defined(OS_POSIX)
15 debug_stub_server_bound_socket(IPC::InvalidPlatformFileForTransit()), 15 debug_stub_server_bound_socket(IPC::InvalidPlatformFileForTransit()),
16 #endif 16 #endif
17 validation_cache_enabled(false), 17 validation_cache_enabled(false),
18 enable_debug_stub(false), 18 enable_debug_stub(false),
19 process_type(kUnknownNaClProcessType), 19 process_type(kUnknownNaClProcessType) {
20 crash_info_shmem_handle(base::SharedMemory::NULLHandle()) {
21 } 20 }
22 21
23 NaClStartParams::NaClStartParams(const NaClStartParams& other) = default; 22 NaClStartParams::NaClStartParams(const NaClStartParams& other) = default;
24 23
25 NaClStartParams::~NaClStartParams() { 24 NaClStartParams::~NaClStartParams() {
26 } 25 }
27 26
28 NaClResourcePrefetchResult::NaClResourcePrefetchResult() 27 NaClResourcePrefetchResult::NaClResourcePrefetchResult()
29 : file(IPC::InvalidPlatformFileForTransit()) { 28 : file(IPC::InvalidPlatformFileForTransit()) {
30 } 29 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 83
85 NaClLaunchParams::NaClLaunchParams(const NaClLaunchParams& other) = default; 84 NaClLaunchParams::NaClLaunchParams(const NaClLaunchParams& other) = default;
86 85
87 NaClLaunchParams::~NaClLaunchParams() { 86 NaClLaunchParams::~NaClLaunchParams() {
88 } 87 }
89 88
90 NaClLaunchResult::NaClLaunchResult() 89 NaClLaunchResult::NaClLaunchResult()
91 : ppapi_ipc_channel_handle(), 90 : ppapi_ipc_channel_handle(),
92 trusted_ipc_channel_handle(), 91 trusted_ipc_channel_handle(),
93 plugin_pid(base::kNullProcessId), 92 plugin_pid(base::kNullProcessId),
94 plugin_child_id(0), 93 plugin_child_id(0) {}
95 crash_info_shmem_handle(base::SharedMemory::NULLHandle()) {
96 }
97 94
98 NaClLaunchResult::NaClLaunchResult( 95 NaClLaunchResult::NaClLaunchResult(
99 const IPC::ChannelHandle& ppapi_ipc_channel_handle, 96 const IPC::ChannelHandle& ppapi_ipc_channel_handle,
100 const IPC::ChannelHandle& trusted_ipc_channel_handle, 97 const IPC::ChannelHandle& trusted_ipc_channel_handle,
101 const IPC::ChannelHandle& manifest_service_ipc_channel_handle, 98 const IPC::ChannelHandle& manifest_service_ipc_channel_handle,
102 base::ProcessId plugin_pid, 99 base::ProcessId plugin_pid,
103 int plugin_child_id, 100 int plugin_child_id,
104 base::SharedMemoryHandle crash_info_shmem_handle) 101 base::SharedMemoryHandle crash_info_shmem_handle)
105 : ppapi_ipc_channel_handle(ppapi_ipc_channel_handle), 102 : ppapi_ipc_channel_handle(ppapi_ipc_channel_handle),
106 trusted_ipc_channel_handle(trusted_ipc_channel_handle), 103 trusted_ipc_channel_handle(trusted_ipc_channel_handle),
107 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle), 104 manifest_service_ipc_channel_handle(manifest_service_ipc_channel_handle),
108 plugin_pid(plugin_pid), 105 plugin_pid(plugin_pid),
109 plugin_child_id(plugin_child_id), 106 plugin_child_id(plugin_child_id),
110 crash_info_shmem_handle(crash_info_shmem_handle) { 107 crash_info_shmem_handle(crash_info_shmem_handle) {
111 } 108 }
112 109
113 NaClLaunchResult::~NaClLaunchResult() { 110 NaClLaunchResult::~NaClLaunchResult() {
114 } 111 }
115 112
116 } // namespace nacl 113 } // namespace nacl
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698