Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2849603005: Do not reinvent the wheel / use content APIs to find a frame by name. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
index 8f75b85f02320d7b629536c1ee901f443db8b489..f2b33b62f3def4579affca14f73fb5d2374c5a71 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
@@ -25,6 +25,7 @@
#include "content/public/browser/navigation_throttle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
#include "content/public/test/mock_render_process_host.h"
#include "content/public/test/navigation_simulator.h"
#include "content/public/test/test_renderer_host.h"
@@ -267,12 +268,9 @@ class ContentSubresourceFilterDriverFactoryTest
MockSubresourceFilterClient* client() { return client_; }
content::RenderFrameHost* GetSubframeRFH() {
- for (content::RenderFrameHost* rfh :
- RenderViewHostTestHarness::web_contents()->GetAllFrames()) {
- if (rfh->GetFrameName() == kSubframeName)
- return rfh;
- }
- return nullptr;
+ return content::FrameMatchingPredicate(
+ RenderViewHostTestHarness::web_contents(),
+ base::Bind(&content::FrameMatchesName, kSubframeName));
}
void ExpectActivationSignalForFrame(content::RenderFrameHost* rfh,

Powered by Google App Engine
This is Rietveld 408576698