Do not reinvent the wheel / use content APIs to find a frame by name.

chrome/browser/autofill/autofill_interactive_uitest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 197 matching lines @@
   bool waiting_for_text_change_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillManagerTestDelegateImpl);
 };
 
 // Searches all frames of |web_contents| and returns one called |name|. If
 // there are none, returns null, if there are more, returns an arbitrary one.
 content::RenderFrameHost* RenderFrameHostForName(
     content::WebContents* web_contents,
     const std::string& name) {
-  for (content::RenderFrameHost* frame : web_contents->GetAllFrames()) {
-    if (frame->GetFrameName() == name)
-      return frame;
-  }
-  return nullptr;
+  return content::FrameMatchingPredicate(
+      web_contents, base::Bind(&content::FrameMatchesName, name));

[Łukasz Anforowicz, 2017/04/27 21:36:32]

Given how often the pattern above is used, I wonder if I shouldn't go one step
further and add to content/public/test/browser_test_utils.h a
FrameMatchingName(WebContents, const std::string&) function.  This would allow
ripping out the method reimplemented in the 3 (or 4 depending how you count)
tests I am touching here.

[Łukasz Anforowicz, 2017/04/27 22:59:28]

WDYT about the above?  This would simplify the test code a bit further (at the
cost of exposing everything and a kitchen sync from browser_test_utils.h - this
doesn't seem that bad to me, as long as the new function has a reasonably
obvious name)

[ncarter (slow), 2017/04/27 23:13:35]

Should we instead expose a FindFrameByName to web_contents.h? There seems to be
demand for it in real code.

 }
 
 }  // namespace
 
 // AutofillInteractiveTest ----------------------------------------------------
 
 class AutofillInteractiveTest : public InProcessBrowserTest {
  protected:
   AutofillInteractiveTest() :
       key_press_event_sink_(
@@ skipping 1627 matching lines @@
   std::string script_focus(
       "window.focus();"
       "document.getElementById('CREDIT_CARD_NUMBER').focus();");
   ASSERT_TRUE(content::ExecuteScript(cross_frame, script_focus));
 
   // Send an arrow dow keypress in order to trigger the autofill popup.
   SendKeyToPageAndWait(ui::DomKey::ARROW_DOWN);
 }
 
 }  // namespace autofill