Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: ui/app_list/search/history_data_store_unittest.cc

Issue 2849603003: Use ScopedTaskEnvironment instead of MessageLoopForUI in ui tests. (Closed)
Patch Set: CR-add-newline-after-include Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/search/history_data_store_unittest.cc
diff --git a/ui/app_list/search/history_data_store_unittest.cc b/ui/app_list/search/history_data_store_unittest.cc
index 9b582d68bec46b07b6655102ac23c875cea3b2fe..f2be0a4d85920883ce862d475d79b7aec58b5410 100644
--- a/ui/app_list/search/history_data_store_unittest.cc
+++ b/ui/app_list/search/history_data_store_unittest.cc
@@ -2,18 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "ui/app_list/search/history_data_store.h"
+
#include "base/bind.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/macros.h"
#include "base/memory/ref_counted.h"
-#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/test/sequenced_worker_pool_owner.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/app_list/search/dictionary_data_store.h"
#include "ui/app_list/search/history_data.h"
-#include "ui/app_list/search/history_data_store.h"
namespace app_list {
namespace test {
@@ -41,7 +42,10 @@ std::string GetDataContent(const HistoryData::Data& data) {
class HistoryDataStoreTest : public testing::Test {
public:
- HistoryDataStoreTest() : worker_pool_owner_(2, "AppLanucherTest") {}
+ HistoryDataStoreTest()
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI),
+ worker_pool_owner_(2, "AppLanucherTest") {}
// testing::Test overrides:
void SetUp() override {
@@ -89,7 +93,7 @@ class HistoryDataStoreTest : public testing::Test {
run_loop_->Quit();
}
- base::MessageLoopForUI message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
base::ScopedTempDir temp_dir_;
base::FilePath data_file_;
std::unique_ptr<base::RunLoop> run_loop_;

Powered by Google App Engine
This is Rietveld 408576698