Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2849593002: Use is_same_document term instead of is_in_page for metrics. (Closed)
Patch Set: Addressed review comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « components/navigation_metrics/navigation_metrics.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9d3aff3a9f2721c2a09e4edb41a05a01fd812015..ba76f7beb6b4bdfe4607da6ff100bfc540735407 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -31956,9 +31956,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>elawrence@chromium.org</owner>
<owner>estark@chromium.org</owner>
<summary>
- The scheme of the URL for each main-frame navigation that goes to a
- different page. Transitions like fragment change or history.pushState are
- excluded.
+ The scheme of the URL for each main-frame navigation that replaces a
+ document object. This is not reported for reference fragment navigations,
+ pushState/replaceState or same page history navigation.
</summary>
</histogram>
@@ -31967,9 +31967,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>elawrence@chromium.org</owner>
<owner>estark@chromium.org</owner>
<summary>
- The scheme of the URL for each main-frame navigation that goes to a
- different page while in incognito. Transitions like fragment change or
- history.pushState are excluded.
+ The scheme of the URL for each main-frame navigation that replaces a
+ document object while in incognito. This is not reported for reference
+ fragment navigations, pushState/replaceState or same page history
+ navigation.
</summary>
</histogram>
« no previous file with comments | « components/navigation_metrics/navigation_metrics.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698