components/navigation_metrics/navigation_metrics.h - Issue 2849593002: Use is_same_document term instead of is_in_page for metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_metrics/navigation_metrics.h

Issue 2849593002: Use is_same_document term instead of is_in_page for metrics. (Closed)

Patch Set: Addressed review comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/navigation_metrics/navigation_metrics.h

diff --git a/components/navigation_metrics/navigation_metrics.h b/components/navigation_metrics/navigation_metrics.h

index febc8b8b342654a8984af997a6aeb4ee08093faf..1475d6e1801fda92065d44d48634de188b8efda7 100644

--- a/components/navigation_metrics/navigation_metrics.h

+++ b/components/navigation_metrics/navigation_metrics.h

@@ -10,7 +10,7 @@ class GURL;

namespace navigation_metrics {

void RecordMainFrameNavigation(const GURL& url,

- bool is_in_page,

+ bool is_same_document,

bool is_off_the_record);

} // namespace navigation_metrics

« no previous file with comments | « no previous file | components/navigation_metrics/navigation_metrics.cc » ('j') | no next file with comments »