tools/metrics/histograms/histograms.xml - Issue 2849593002: Use is_same_document term instead of is_in_page for metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2849593002: Use is_same_document term instead of is_in_page for metrics. (Closed)

Patch Set: Addressed review comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 9d3aff3a9f2721c2a09e4edb41a05a01fd812015..ba76f7beb6b4bdfe4607da6ff100bfc540735407 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -31956,9 +31956,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>elawrence@chromium.org</owner>

<owner>estark@chromium.org</owner>

- The scheme of the URL for each main-frame navigation that goes to a

- different page. Transitions like fragment change or history.pushState are

- excluded.

+ The scheme of the URL for each main-frame navigation that replaces a

+ document object. This is not reported for reference fragment navigations,

+ pushState/replaceState or same page history navigation.

</summary>

</histogram>

@@ -31967,9 +31967,10 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<owner>elawrence@chromium.org</owner>

<owner>estark@chromium.org</owner>

- The scheme of the URL for each main-frame navigation that goes to a

- different page while in incognito. Transitions like fragment change or

- history.pushState are excluded.

+ The scheme of the URL for each main-frame navigation that replaces a

+ document object while in incognito. This is not reported for reference

+ fragment navigations, pushState/replaceState or same page history

+ navigation.

</summary>

</histogram>

« no previous file with comments | « components/navigation_metrics/navigation_metrics.cc ('k') | no next file » | no next file with comments »