Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4397)

Unified Diff: build/toolchain/gcc_toolchain.gni

Issue 2849583005: Disable linker map for Clang toolchains. (Closed)
Patch Set: !use_lld Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/gcc_toolchain.gni
diff --git a/build/toolchain/gcc_toolchain.gni b/build/toolchain/gcc_toolchain.gni
index dfd187954cd148c690223a913eeac524a85e269c..be55c0fe8b34c408d8477f0f21f8aeac72bb74ec 100644
--- a/build/toolchain/gcc_toolchain.gni
+++ b/build/toolchain/gcc_toolchain.gni
@@ -248,8 +248,10 @@ template("gcc_toolchain") {
extra_ldflags = ""
}
- enable_linker_map =
- defined(invoker.enable_linker_map) && invoker.enable_linker_map
+ # Currently disabled on LLD because of a bug (fixed upstream).
+ # See https://crbug.com/716209.
+ enable_linker_map = defined(invoker.enable_linker_map) &&
+ invoker.enable_linker_map && !use_lld
# These library switches can apply to all tools below.
lib_switch = "-l"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698