chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc - Issue 2849523003: Add billing address as a mandatory field of Payments credit cards.

Unified Diff: chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Issue 2849523003: Add billing address as a mandatory field of Payments credit cards. (Closed)

Patch Set: Components Unittests fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc ('K') | « chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc ('k') | components/autofill/core/browser/BUILD.gn » ('j') | components/autofill/core/browser/address_combobox_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

diff --git a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

index 71612412ef9bd586ff1ca8972f42ca3d6ab85dd1..8b2ae56513e08c396af85ec737d5a4adecf66d9b 100644

--- a/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

+++ b/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

@@ -166,7 +166,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest, SyncData) {

base::RunLoop data_loop;

EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())

.WillOnce(QuitMessageLoop(&data_loop));

- ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON);

+ ClickOnDialogViewAndWait(DialogViewID::SAVE_ADDRESS_BUTTON);

data_loop.Run();

ASSERT_EQ(1UL, personal_data_manager->GetProfiles().size());

@@ -204,7 +204,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest, AsyncData) {

base::RunLoop data_loop;

EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())

.WillOnce(QuitMessageLoop(&data_loop));

- ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON);

+ ClickOnDialogViewAndWait(DialogViewID::SAVE_ADDRESS_BUTTON);

data_loop.Run();

ASSERT_EQ(1UL, personal_data_manager->GetProfiles().size());

@@ -344,7 +344,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest,

base::RunLoop data_loop;

EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())

.WillOnce(QuitMessageLoop(&data_loop));

- ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON);

+ ClickOnDialogViewAndWait(DialogViewID::SAVE_ADDRESS_BUTTON);

data_loop.Run();

ASSERT_EQ(1UL, personal_data_manager->GetProfiles().size());

@@ -383,7 +383,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest,

base::RunLoop data_loop;

EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())

.WillOnce(QuitMessageLoop(&data_loop));

- ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON);

+ ClickOnDialogViewAndWait(DialogViewID::SAVE_ADDRESS_BUTTON);

data_loop.Run();

ASSERT_EQ(1UL, personal_data_manager->GetProfiles().size());

@@ -434,7 +434,7 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestShippingAddressEditorTest,

base::RunLoop data_loop;

EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())

.WillOnce(QuitMessageLoop(&data_loop));

- ClickOnDialogViewAndWait(DialogViewID::EDITOR_SAVE_BUTTON);

+ ClickOnDialogViewAndWait(DialogViewID::SAVE_ADDRESS_BUTTON);

data_loop.Run();

ExpectExistingRequiredFields(/*unset_types=*/nullptr);